Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
11862Feature requestsSurvey takingpublic2021-09-28 16:41
ReporterDenisChenu Assigned Togalads  
PrioritynoneSeverityfeature 
Status acknowledgedResolutionreopened 
Fixed in Version3.0 
Summary11862: 2 real step clearall
DescriptionActually clearall is 2 click : OK why not.
But i really think it's better if we have a real 2 step behaviour:
- Click on clearall
- Show a confirmation box with : "Confirm" and "Cancel" : cancel is a return to survey link
Additional InformationWe can use form.pstpl here.
Add a checkbox for real confirmation with required ?

PS : i add language Yes, No to do a better confirm box, but think 2step action is always bette.
Tagsanswers_html
Bug heat10

Relationships

related to 17623 confirmedgalads Bug reports Very hard to clear all with JS and keyboard navigation 

Activities

DenisChenu

DenisChenu

2016-11-03 18:30

developer   ~41705

@olle , @LouisGac , @c_schmitz ?
It's really my opinion here.

I'm not sure what is the desired behaviour.
LouisGac

LouisGac

2016-11-04 11:52

developer   ~41716

I think you're right.
DenisChenu

DenisChenu

2016-11-28 10:01

developer   ~42247

Just to confirm : Carsten is OK too ? You discuss about it ?

Because i'm the only one to vote.
ollehar

ollehar

2016-11-29 14:57

administrator   ~42254

Think it should be Bootstrap modal instead of JS confirm(), but don't see a need for two-page confirm.
Mazi

Mazi

2016-11-30 16:49

partner   ~42300

I prefer a nicer popup/modal with maybe a big WARNING message on top.
DenisChenu

DenisChenu

2016-12-02 14:59

developer   ~42316

Oups ....

OK i have the javascript way :
- core : use confirm BUT confirmSurveyDialog(text,title,submits) : limesurvey package use confirm and send submit after
- default update thius function to show another dioalog box.

I just need another fix for no js currently, better fix.
DenisChenu

DenisChenu

2016-12-02 17:59

developer   ~42320

Added confirmSurveyDialog javascript function and use a bs confirm dialog in default template
DenisChenu

DenisChenu

2019-10-03 17:20

developer   ~53869

Reopen : fix deleted when move to twig
galads

galads

2021-08-19 16:02

administrator   ~66077

I think there are already popups for confirmation. If not, can you point out where?
DenisChenu

DenisChenu

2021-08-21 11:53

developer   ~66097

Still not a real 2 time step : 2 different page.

Without JS : iy's hard to undertand, with browser read : it's hard to understand.

If confirm is not set : currently nothing happen. Muts show a page with Confirm and Cancel.

I do it in pre 3 release.
DenisChenu

DenisChenu

2021-08-21 11:55

developer   ~66098

See : https://github.com/LimeSurvey/LimeSurvey/commit/3af89f9a3db0d7244961fa6cc2164b22612aa37c#diff-f2c0610f506dc0397d2efd8d8203a78dc44f2825e26eb0ac70efd87205d2e36eR1669

A form is here wihout js and screen reader
DenisChenu

DenisChenu

2021-09-28 16:41

developer   ~66635

Can be done in theme : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/3d1222a6a097c28bbe94d14163b83f7e97b0152c

Still think it's better, more comprehensible and easy to use than a popup. But can close if you want.

Related Changesets

LimeSurvey: develop 3af89f9a

2016-12-02 17:52:17

DenisChenu

Details Diff
New feature : default template use a boostrap dialog for clearall
Dev: 2 step without js is done too
Dev: core use confirm, related to feature 11970
Affected Issues
11862
mod - application/controllers/survey/index.php Diff File
mod - application/core/packages/limesurvey/survey.js Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/frontend_helper.php Diff File
mod - application/helpers/replacements_helper.php Diff File
add - application/views/survey/frontpage/clearallForm/form.php Diff File
add - application/views/survey/frontpage/clearallForm/heading.php Diff File
add - application/views/survey/frontpage/clearallForm/message.php Diff File
mod - application/views/survey/system/actionButton/clearAll.php Diff File
mod - application/views/survey/system/actionLink/clearAll.php Diff File
mod - application/views/survey/system/surveyIndex/groupIndexMenuLink.php Diff File
mod - application/views/survey/system/surveyIndex/questionIndexMenuLink.php Diff File
mod - templates/default/css/template.css Diff File
mod - templates/default/scripts/template.js Diff File
mod - templates/default/views/endpage.pstpl Diff File
mod - templates/default/views/navigator.pstpl Diff File
mod - templates/default/views/survey.pstpl Diff File
mod - templates/default/views/welcome.pstpl Diff File

Issue History

Date Modified Username Field Change
2016-11-03 18:29 DenisChenu New Issue
2016-11-03 18:30 DenisChenu Tag Attached: answers_html
2016-11-03 18:30 DenisChenu Note Added: 41705
2016-11-04 11:52 LouisGac Note Added: 41716
2016-11-28 10:00 DenisChenu Assigned To => DenisChenu
2016-11-28 10:00 DenisChenu Status new => assigned
2016-11-28 10:01 DenisChenu Assigned To DenisChenu => LouisGac
2016-11-28 10:01 DenisChenu Status assigned => feedback
2016-11-28 10:01 DenisChenu Note Added: 42247
2016-11-29 08:01 DenisChenu Assigned To LouisGac => DenisChenu
2016-11-29 14:57 ollehar Note Added: 42254
2016-11-30 16:49 Mazi Note Added: 42300
2016-12-02 14:55 DenisChenu Assigned To DenisChenu =>
2016-12-02 14:55 DenisChenu Assigned To => DenisChenu
2016-12-02 14:55 DenisChenu Status feedback => assigned
2016-12-02 14:59 DenisChenu Note Added: 42316
2016-12-02 17:58 DenisChenu Changeset attached => LimeSurvey develop 3af89f9a
2016-12-02 17:59 DenisChenu Note Added: 42320
2016-12-02 17:59 DenisChenu Status assigned => resolved
2016-12-02 17:59 DenisChenu Resolution open => fixed
2016-12-02 17:59 DenisChenu Fixed in Version => 3.0
2018-04-06 11:48 markusfluer Status resolved => closed
2019-10-03 17:20 DenisChenu Assigned To DenisChenu =>
2019-10-03 17:20 DenisChenu Status closed => feedback
2019-10-03 17:20 DenisChenu Resolution fixed => reopened
2019-10-03 17:20 DenisChenu Note Added: 53869
2021-08-19 16:02 galads Note Added: 66077
2021-08-19 16:02 galads Bug heat 8 => 10
2021-08-21 11:53 DenisChenu Note Added: 66097
2021-08-21 11:53 DenisChenu Status feedback => new
2021-08-21 11:55 DenisChenu Note Added: 66098
2021-09-24 14:35 DenisChenu Relationship added related to 17623
2021-09-27 11:19 galads Assigned To => galads
2021-09-27 11:19 galads Status new => acknowledged
2021-09-28 16:41 DenisChenu Note Added: 66635