Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17628Bug reportsTranslationpublic2021-11-01 16:09
Reporterlfanfoni Assigned Togabrieljenik  
PrioritynoneSeveritytext 
Status assignedResolutionfixed 
Product Version5.x 
Summary17628: Inconsistent error message in case of soft mandatory
DescriptionI noticed in version 5 an inconsistency in the English message that appears when mandatory is violated. Even when the "soft" option is activated, this message is shown:
"One or more mandatory questions have not been answered. You cannot proceed until these have been completed."
I suggest to mantain only the first sentence.
Steps To Reproduce1) create a simple survey with a text question and set the mandatory as "Soft"
2) preview the survey
3) leave blank the text question
4) click to "Next" or "Send"
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)5.0.8+210712
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySql
Server OS (if known)
Webserver software & version (if known)
PHP Versioncurrent

Relationships

related to 17333 confirmedgabrieljenik Soft mandatory show as mandatory : produces an incomprehensible form 

Activities

DenisChenu

DenisChenu

2021-09-27 15:57

developer   ~66625

https://twitter.com/annso_/status/1397551474574598146
galads

galads

2021-10-06 12:12

administrator   ~66769

Last edited: 2021-10-06 12:13

Hello, thank you for reporting this issue. Do you mean the popup message? "You cannot proceed until you enter some text for one or more questions."

It should change to only "One or more mandatory questions have not been answered"
DenisChenu

DenisChenu

2021-10-06 12:29

developer   ~66773

> It should change to only "One or more mandatory questions have not been answered"

I think , you need something like «There are question that must be confirmed as not answered» or something like this
gabrieljenik

gabrieljenik

2021-10-20 15:12

manager   ~66880

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2108
Created specific message for soft mandatory warnings.

Test should consider mandatory and soft mandatory as to make sure mandatory still works as expected.
gabrieljenik

gabrieljenik

2021-11-01 16:09

manager   ~67031

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32841

Related Changesets

LimeSurvey: master cedc64ea

2021-10-19 21:17:07

gabrieljenik

Details Diff
Fixed issue 17628: Inconsistent error message in case of soft mandatory Affected Issues
17628
mod - application/helpers/qanda_helper.php Diff File

LimeSurvey: master 71c97c58

2021-10-21 21:30:20

gabrieljenik

Details Diff
Fixed issue 17628: Inconsistent error message in case of soft mandatory

- Fix for 'Show popups = On page'
Affected Issues
17628
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File

LimeSurvey: master 6bb4ba6e

2021-11-01 16:09:23

Ahmed Galad's


Committer: GitHub Details Diff
Merge pull request #2108 from gabrieljenik/bug/17628--Inconsistent-error-message-in-case-of-soft-mandatory

Fixed issue 17628: Inconsistent error message in case of soft mandatory
Affected Issues
17628
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/qanda_helper.php Diff File

Issue History

Date Modified Username Field Change
2021-09-27 15:54 lfanfoni New Issue
2021-09-27 15:56 DenisChenu Relationship added related to 17333
2021-09-27 15:57 DenisChenu Note Added: 66625
2021-09-27 15:57 DenisChenu Bug heat 0 => 2
2021-09-28 08:39 galads Assigned To => galads
2021-09-28 08:39 galads Status new => confirmed
2021-10-06 12:12 galads Note Added: 66769
2021-10-06 12:12 galads Bug heat 2 => 4
2021-10-06 12:13 galads Assigned To galads => gabrieljenik
2021-10-06 12:13 galads Status confirmed => assigned
2021-10-06 12:29 DenisChenu Note Added: 66773
2021-10-20 15:12 gabrieljenik Note Added: 66880
2021-10-20 15:12 gabrieljenik Bug heat 4 => 6
2021-11-01 16:09 Changeset attached => LimeSurvey master 6bb4ba6e
2021-11-01 16:09 gabrieljenik Changeset attached => LimeSurvey master 71c97c58
2021-11-01 16:09 gabrieljenik Changeset attached => LimeSurvey master cedc64ea
2021-11-01 16:09 gabrieljenik Note Added: 67031
2021-11-01 16:09 gabrieljenik Resolution open => fixed