PS : adding pattern and required must be done AFTER fix it in PHP (never think user can not update HTML)

See (after https://github.com/LimeSurvey/LimeSurvey/pull/2331)
When using Save : it's really NEAR the best solution : stay there, don't update anything and don't save invalid value.

Still 2 issue :

• Use a better view (not a print_r)
• Save other answer (and show error if needed)

So, we need complement this solution (https://github.com/LimeSurvey/LimeSurvey/pull/2331) by showing friendlier errors?

No : this issue is related to sub-question code.

BUT : answer code have same issue :) then must be fixed in same way :)

[EDIT] subquestion save (bot save and close) don't throw 500 error

Now that 17929 is fixed, do we need this?

See screencast : not related to answer code , but to sub-question code ,
Then we still need it (for subquestion)

Using save : it's OK
Using save and close : it's broken.

The validation is already happening at subquestion level.

The error that you were shown is OK. Seems like a dump but I guess that's because of the debug mode?
We couldn't reproduce it exactly like that on 5.3

BTW: Answer Codes with strange characters were saved, no dumps. It is not supposed to accept those characters, so the rules added on the other ticket are fine.

image.png (20,194 bytes)   

image.png (20,194 bytes)   

image-2.png (81,940 bytes)   

image-2.png (81,940 bytes)   

No need debug at 2 :
see screencast ,

1. "Save and close" => throw 500 error
2. "Save" => Better , didn't loose anything, but
   1. Error shown is ugly (and must be improved)
   2. Show only the 1st error

Save and Close button is not submitting the form through Ajax.
From what I see, the save controller can't handle errors in a non-ajax way.
Option 1: Update how controller send errors to front in non-ajax cases.
Option 2: Make "save and close" to send Ajax and also work on a call back to redirect to "view mode" after.

Option 3 : send ->validate in ajax (and return error) and ->save in PHP

:)

Adding an error handler for the case when the save is not done using ajax.

Although it now shows the error in an alert, its content is still ugly (the print_r is still there).
It could be necessary to add validations in JS, because although now it does not throw the 500 error, it makes a redirect, and therefore the data is lost.

Side note, to review later: LSJsonExceptions are supposed to be handled by the SurveysController in the actionError() method, only when it's an AJAX request. But when it's AJAX it never gets there, because it gets caught before LSYii_Application::onException() (line 403). It would be necessary to add one more condition to that IF, excluding the LSJsonException. (will create a ticket for that)

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2343

Here : https://github.com/LimeSurvey/LimeSurvey/blob/cd03fc7ed0d2840b4462994e5e4dc1a340b63796/application/core/LSYii_Application.php#L402

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33450

Fixed in Release 5.3.12+220502

I get the exact same error as shown at https://bugs.limesurvey.org/file_download.php?file_id=15813&type=bug when trying to use "other" as subquestion code at an array question.
The error message ois misleading though:
"An error happened: Could not save subquestion Array ( [title] => Array ( [0] => 'other' can not be used if the 'Other' option for this question is activated. ) )"

-> There simply is no "other" option for array questions. So to make array filter work with e.g. a multi choice question with "other" field, it would be great if we could accept "other" as subquestion code for arrays.

image-3.png (84,484 bytes)   

image-3.png (84,484 bytes)   

I get the exact same error as shown at https://bugs.limesurvey.org/file_download.php?file_id=15813&type=bug when trying to use "other" as subquestion code at an array question.

Correct link to file is https://bugs.limesurvey.org/file_download.php?file_id=15813&type=bug :)
Also, the message n that file is different than the screenshot, isn't it?

@mazi I hate to ask for this, but can I ask you to open a new ticket for this matter?