Something to check: Are the question type defaults user specific (they should) or global (god, please no).

inherited by survey/group/global :D

inherited by survey/group/global :D

lol, I hope that was a joke ;)

https://github.com/LimeSurvey/LimeSurvey/pull/2386

The value of the front_end switch depended on use_defaults, which has nothing to do with it. Now it always appears disabled, as this a one way switch: You can only set it to true and then defaults will be snapshot and saved. There is no link in between the default values sanpshot and the current question attributes. Question attributes can later be changed, and the default wouldn't be impacted.

Defaults were saved but not used for populating new questions. Now they do.

Tbh,. I am not sure how the default values are applied on a new question, because the question type is only select after the `default are already loaded

I think you have a good argument there.
TBH, not big fan of this feature nor not sure how whidely used it is.

TBH, not big fan of this feature nor not sure how whidely used it is.

+1 here

Else : the best place seems to be in QuestionAttribute or QuestionAttributeHelper ?

here : https://github.com/LimeSurvey/LimeSurvey/blob/b174a7d10a29017f120e9b0d47089b7b8240b668/application/models/services/QuestionAttributeHelper.php#L41 maybe

QuestionAttributeFetcher does the following:

        // Get attribute values
        if (!empty($this->question->qid)) {
            $attributeValues = \QuestionAttribute::model()->getAttributesAsArrayFromDB($this->question->qid);
        } else {
            $attributeValues = $questionAttributeHelper->getUserDefaultsForQuestionType($this->question->type);
        }

In populateValues(), if the question is new (has no QID) it raises the default values.
So if you are creating a question and you change the type of question, without saving, it raises the defaults for the last type you chose.
It never changes the values if you are changing the type of a previously saved question.

That is kind the behaviour it used to have. Haven't changed it. Just fixed what was not working correctly.

I am not sure it is great feature. :)

But :

Save 'placeholder' "enter a number" default value for numeric
Create a short text question
Save
Set it as numeric question type : 'placeholder' must be "enter a number" ? No ?

Set it as numeric question type : 'placeholder' must be "enter a number" ? No ?

Hmm If I got it right, no, it must not.
If you save and then change the question type, the default values will not apply.
The default values only apply for new questions, before they are saved.

It's not like that i understand the default value by question type :)
For me it must replace the default value for new question, or new attribute in same question (happen when you update question type)

It's more clear with

1. Create a single choice question
2. Save (no placeholder attribute (not set))
3. Set it as numeric question type : 'placeholder' must be "enter a number" ? No ?

Short text didn't have placeholder too . If short text have it with already saved : yes , must not update.

@c_schmitz : do you have any specifications for this feature ?

OK, how these defaults are applied was not specifically in the scope of this ticket.
I would suggest to follow up on a new ticket, as to be able to deliver this (which I believe is better than what is available now)
What do you think?

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33530

Fixed in Release 5.3.18+220530