Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18491Bug reportsTheme editorpublic2023-01-09 11:01
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18491: List of fonts and colors should be sorted alphabetically
Description

Caught while reviewing 18463

Steps To Reproduce

Steps to reproduce

Open the theme options of a theme which has several fonts and colors variations.

Expected result

See available options at dropdown in alphabetical order.

Actual result

List is completely un-ordered.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)5.x
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMariaDB 10.1.48
Server OS (if known)
Webserver software & version (if known)
PHP VersionPHP 7.4

Relationships

related to 18463 closedollehar List of uploaded files should be sorted alphabetically 

Activities

DenisChenu

DenisChenu

2022-11-16 17:28

developer   ~72776

For variations : order is set by confix.xml
https://github.com/LimeSurvey/LimeSurvey/blob/b10a1b17c3d25d08867fe19cea6915b1b644ffc4/themes/survey/bootswatch/config.xml#L74

I really think we mist not update it.
Theme developer set this order : don't update this order automatically.

OR only via extra options

<cssframework type="dropdown" category="Simple options" width="12" title="Variations" parent="cssframework" alphabeticalorder="1">

gabrieljenik

gabrieljenik

2022-12-15 17:39

manager   ~73149

OK to sort fonts alphabeticalorder ?

DenisChenu

DenisChenu

2022-12-15 17:48

developer   ~73153

OK to sort fonts alphabeticalorder ?

Just update font list in theme.xml, no ?

gabrieljenik

gabrieljenik

2022-12-29 15:15

manager   ~73315

https://github.com/LimeSurvey/LimeSurvey/pull/2820

gabrieljenik

gabrieljenik

2023-01-04 10:47

manager   ~73348

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=34198

LimeBot

LimeBot

2023-01-09 11:01

administrator   ~73390

Fixed in Release 5.5.2+230109

Related Changesets

LimeSurvey: master 607adced

2023-01-04 10:41:05

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 18491: Theme editor : List of fonts and colors should be sorted alphabetically (#2820)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18491
mod - application/config/fonts.php Diff File
mod - themes/survey/fruity/config.xml Diff File
mod - themes/survey/vanilla/config.xml Diff File

Issue History

Date Modified Username Field Change
2022-11-16 14:20 gabrieljenik New Issue
2022-11-16 14:20 gabrieljenik Issue generated from: 18463
2022-11-16 14:20 gabrieljenik Relationship added related to 18463
2022-11-16 14:20 gabrieljenik Status new => confirmed
2022-11-16 17:28 DenisChenu Note Added: 72776
2022-11-16 17:28 DenisChenu Bug heat 0 => 2
2022-12-15 17:39 gabrieljenik Note Added: 73149
2022-12-15 17:39 gabrieljenik Bug heat 2 => 4
2022-12-15 17:48 DenisChenu Note Added: 73153
2022-12-29 15:15 gabrieljenik Assigned To => gabrieljenik
2022-12-29 15:15 gabrieljenik Status confirmed => ready for code review
2022-12-29 15:15 gabrieljenik Note Added: 73315
2022-12-29 15:15 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-01-02 08:44 DenisChenu Assigned To DenisChenu =>
2023-01-02 08:44 DenisChenu Status ready for code review => ready for testing
2023-01-03 15:37 gabrieljenik Assigned To => ollehar
2023-01-03 15:37 gabrieljenik Status ready for testing => ready for merge
2023-01-04 10:47 gabrieljenik Changeset attached => LimeSurvey master 607adced
2023-01-04 10:47 gabrieljenik Note Added: 73348
2023-01-04 10:47 gabrieljenik Assigned To ollehar => gabrieljenik
2023-01-04 10:47 gabrieljenik Resolution open => fixed
2023-01-09 11:01 LimeBot Note Added: 73390
2023-01-09 11:01 LimeBot Status ready for merge => closed
2023-01-09 11:01 LimeBot Bug heat 4 => 6