View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
14980Bug reportsTheme editorpublic2021-11-26 15:20
ReporterDenisChenu Assigned Togalads  
PrioritynormalSeveritypartial_block 
Status assignedResolutionopen 
Product Version3.25.17 
Summary14980: Multiple variation loaded
DescriptionVariation load all parent variation
Steps To Reproduce1. Set skyline_blue for variation
2. Extend fruity to fruity1 : set black_pearl for variation
3. Extend fruity1 to fruity2 : set purple_tentacle for variation

Choose fruity2 for a survey, look at css loaded.
Additional InformationWith included survey : it's OK, with skelvanilla : loading of [radiocheckbox.less](https://gitlab.com/SondagesPro/SurveyThemes/less-skelvanilla/blob/master/skelvanilla/radiocheckbox.less) show buttons even if [theme-awesome.less](https://gitlab.com/SondagesPro/SurveyThemes/less-skelvanilla/blob/master/theme-awesome.less) is loaded …
Then always show button …

Then i take and fix it …
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)3.17.5 github
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 17141 feedbackgalads Multiple variation loaded 

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2019-06-16 16:11

developer  

DenisChenu

DenisChenu

2019-06-16 18:35

developer   ~52422

skelvanilla didn't use same options.js …
DenisChenu

DenisChenu

2019-06-17 17:37

developer   ~52431

@LouisGac : there aren‘t included clean solution currently … seems `simple_edit_cssframework_css` system are totally removed from solution.

1. There still have php issue with 'replace' : one files can be repleced one time (last replace must remove previous replace)
2. Current variation is add, not replace …

I do my own variation system in SkelVanilla, can‘t use LimeSurvey broken core
DenisChenu

DenisChenu

2021-02-26 18:45

developer   ~62540

@ollehar : can we set this to a better priority ? All usage of variation is broken currently …
ollehar

ollehar

2021-02-26 20:36

administrator   ~62541

In LS3 or 4?
DenisChenu

DenisChenu

2021-02-27 09:07

developer   ~62544

LS3 , i check to fix yesterday

I found one issue here : https://github.com/LimeSurvey/LimeSurvey/blob/84e7ae059c2717d040a0cb65de21e242dc35c051/application/models/TemplateConfig.php#L358

`$toReplace` seems to be an array with $fileToReplace => $fileReplacement .

maybe someone start to work on it but not ending ?

I revert a fix for uploader yesterday : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/a9330f1f027abc22fd86769b81e44608d1019263

You're right : i must check with 4.4 too, maybe it's fixed here.
DenisChenu

DenisChenu

2021-02-27 09:08

developer   ~62545

PS : i really think all TemplateConfig etc … are a mess currently …
DenisChenu

DenisChenu

2021-02-27 12:33

developer   ~62562

LS4 have same issue https://bugs.limesurvey.org/view.php?id=17141
DenisChenu

DenisChenu

2021-02-27 12:37

developer   ~62564

Move to partial_block : this broke all usage of variation with skelvanilla
DenisChenu

DenisChenu

2021-03-10 17:41

developer   ~63100

Still an issue in 3.25.17
galads

galads

2021-11-01 11:11

administrator   ~67018

@DenisChenu , is this a problem in LS5?
DenisChenu

DenisChenu

2021-11-26 15:08

developer   ~67588

I try to check with 5.X , but still have same issue,
Let me check if i didn't reproduce on current master
DenisChenu

DenisChenu

2021-11-26 15:20

developer   ~67590

Still issue in both : 3.X and 5.2.3

1. Leave fruity alone (default green
2. Extend to Fruity1 : set to sunset_orange
3. Extend to Fruity2 : set to skyline_blue


Set a survey using Fruity2 : look at source code.

Issue History

Date Modified Username Field Change
2019-06-16 16:11 DenisChenu New Issue
2019-06-16 16:11 DenisChenu Status new => assigned
2019-06-16 16:11 DenisChenu Assigned To => DenisChenu
2019-06-16 16:11 DenisChenu File Added: Capture d’écran du 2019-06-16 16-06-41.png
2019-06-16 18:35 DenisChenu Assigned To DenisChenu =>
2019-06-16 18:35 DenisChenu Status assigned => new
2019-06-16 18:35 DenisChenu Note Added: 52422
2019-06-17 11:11 DenisChenu Assigned To => DenisChenu
2019-06-17 11:11 DenisChenu Status new => assigned
2019-06-17 17:37 DenisChenu Assigned To DenisChenu =>
2019-06-17 17:37 DenisChenu Status assigned => new
2019-06-17 17:37 DenisChenu Note Added: 52431
2021-02-26 18:45 DenisChenu Note Added: 62540
2021-02-26 20:36 ollehar Note Added: 62541
2021-02-27 09:07 DenisChenu Note Added: 62544
2021-02-27 09:08 DenisChenu Note Added: 62545
2021-02-27 12:27 DenisChenu Issue cloned: 17141
2021-02-27 12:33 DenisChenu Relationship added related to 17141
2021-02-27 12:33 DenisChenu Note Added: 62562
2021-02-27 12:37 DenisChenu Severity minor => partial_block
2021-02-27 12:37 DenisChenu Note Added: 62564
2021-03-10 17:35 ollehar Priority none => normal
2021-03-10 17:41 DenisChenu Product Version 3.17.x => 3.25.17
2021-03-10 17:41 DenisChenu Note Added: 63100
2021-11-01 11:11 galads Note Added: 67018
2021-11-01 11:11 galads Bug heat 4 => 6
2021-11-01 11:11 galads Assigned To => galads
2021-11-01 11:11 galads Status new => feedback
2021-11-26 15:08 DenisChenu Note Added: 67588
2021-11-26 15:08 DenisChenu Status feedback => assigned
2021-11-26 15:20 DenisChenu Note Added: 67590
2021-11-26 15:20 DenisChenu File Added: Capture d’écran du 2021-11-26 15-18-11.png