View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
15696 | Bug reports | Survey participants (Tokens) | public | 2020-01-08 15:44 | 2020-01-15 12:26 |
Reporter | Assigned To | DenisChenu | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.21.3 | ||||
Fixed in Version | 3.21.3 | ||||
Summary | 15696: Multiple email addresses in token are not working | ||||
Description | When trying to add multiple email adresses in the token email field | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | LSPRO | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | LSPRO | ||||
Server OS (if known) | LSPRO | ||||
Webserver software & version (if known) | LSPRO | ||||
PHP Version | LSPRO | ||||
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29313 |
|
Please create a better fix … use And don't update anything else |
|
Does not work for me. Correct form? |
|
Tested on branch Shnoulle-master_better_15696, fresh install. |
|
Oh, so it fails if there's a space? Booo. |
|
Can't see any difference in behaviour between current master and branch, except the field being red. Need more info. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29332 |
|
@ollehar : it's a KISS principle … Here the issue was "Multiple email addresses in token are not working" , issue cause by : https://github.com/LimeSurvey/LimeSurvey/commit/0a7bdfa1c166f734d11a1528c8d9a7d61b670ad7#diff-b3718d1de0757aca81853beec9b65ee8R198 Then it's just fixing this. Previous commit have
In my opinion : we must allow invalid email for admin user : but this need a feature request. Think best solution is using email multiple BUT : LimeSurvey admin GUI are not HTML5 ready (and this is not improved in 4.X …) |
|
I need info on how to reproduce exactly. |
|
I could save multiple emails before merging your fix, but the input field was red. That's the only difference? |
|
Fixed in Release 3.21.5+200115 |
|
See https://bugs.limesurvey.org/view.php?id=15696#c55268 other are difference at other point |
|
LimeSurvey: master 1eee6cf2 2020-01-08 15:44:27
|
Fixed issue 15696: Multiple email addresses in token are not working |
Affected Issues 15696 |
|
add - application/core/LSYii_XssValidator.php | Diff File | ||
mod - application/models/TokenDynamic.php | Diff File | ||
mod - application/views/admin/token/tokenform.php | Diff File | ||
LimeSurvey: master ba9d4f94 2020-01-15 11:43:47 Committer: ollehar Details Diff |
Fixed issue 15696: Multiple email addresses in token are not working (#1368) Dev: Revert "Fixed issue 15696: Multiple email addresses in token are not working" Fixed issue 15696: Multiple email addresses in token are not working |
Affected Issues 15696 |
|
rm - application/core/LSYii_XssValidator.php | Diff File | ||
mod - application/models/TokenDynamic.php | Diff File | ||
mod - application/views/admin/token/tokenform.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-01-08 15:44 |
|
New Issue | |
2020-01-08 15:44 |
|
Status | new => assigned |
2020-01-08 15:44 |
|
Assigned To | => markusfluer |
2020-01-08 15:45 |
|
Changeset attached | => LimeSurvey master 1eee6cf2 |
2020-01-08 15:45 |
|
Note Added: 55162 | |
2020-01-08 15:45 |
|
Resolution | open => fixed |
2020-01-08 15:45 |
|
Status | assigned => resolved |
2020-01-08 15:45 |
|
Fixed in Version | => 3.21.3 |
2020-01-10 14:57 | DenisChenu | Status | resolved => feedback |
2020-01-10 14:57 | DenisChenu | Resolution | fixed => reopened |
2020-01-10 14:57 | DenisChenu | Note Added: 55191 | |
2020-01-15 11:35 | ollehar | File Added: Selection_971.png | |
2020-01-15 11:35 | ollehar | File Added: Selection_972.png | |
2020-01-15 11:35 | ollehar | Note Added: 55262 | |
2020-01-15 11:35 | ollehar | Assigned To | markusfluer => DenisChenu |
2020-01-15 11:35 | ollehar | Note Added: 55263 | |
2020-01-15 11:39 | ollehar | Note Added: 55265 | |
2020-01-15 11:41 | ollehar | Note Added: 55266 | |
2020-01-15 11:43 | ollehar | Changeset attached | => LimeSurvey master ba9d4f94 |
2020-01-15 11:43 | DenisChenu | Note Added: 55267 | |
2020-01-15 11:43 | DenisChenu | Resolution | reopened => fixed |
2020-01-15 11:54 | DenisChenu | Note Added: 55268 | |
2020-01-15 11:57 | ollehar | Note Added: 55269 | |
2020-01-15 11:57 | ollehar | Note Added: 55270 | |
2020-01-15 11:59 | lime_release_bot | Note Added: 55275 | |
2020-01-15 11:59 | lime_release_bot | Status | feedback => closed |
2020-01-15 12:26 | DenisChenu | Note Added: 55279 |