accessible_vanilla ?

https://gitlab.com/SondagesPro/SurveyThemes/accessible_vanilla ?
Archived, outdated
But must not broke in 3.X

Reverting to release 3.26.3+210511 fixes it.

accessible_vanilla ?

All themes.

Debug = 2 and stacktrace?

Oh, stacktrace was in other pic, sorry.

No one reported this from our hosting. Strange.

Can it be reproduced on a fresh install?

No.

The problem appears when I set 'use_custom_twig_extensions'=>true in config.php.

Have we scrapped custom twig extensions?

Uh, not that I know of. Denis?

I never use this. Louis add it.

I don't see any difference in the code between 3.x and master here.

application/core/LSYii_Application.php: $aApplicationConfig['components']['twigRenderer']['user_extensions'][] = $extensionClass;

Any ideas? Can you help us reproduce it?

Any ideas? Can you help us reproduce it?

Did you try 'use_custom_twig_extensions'=>true in config.php, and testing a custom twig extension?

Louis has some readme files in /upload/twig/extensions.

testing a custom twig extension

How?

Place this in a survey theme twig file - {{ helloWorld() }}. It will fire Louis' helloWorld() sample function and return "Hello world".

Or, for a sample with a little HTML, upload the attached extension file to /upload/twig/extensions/ and add this to the twig file - {{ testFunction1() | raw }}.

Got it, thanks!

I confirm the error. However, I think the report should be "using custom twig extension breaks survey" since it does not happen for normal customization of themes without using twig extension.

any news on this?

in YIIbase.php 227 is it crashing.

Property "LSETwigViewRenderer.user_extensions, we make "new" there, for LSETwigViewRenderer. Mustn't the class have the property "user_extensions".? It does not! I can't find this in 3.26, too.

That is your opinion, not mine! Are you just going to ignore the bug?

There are more than 1000 bugs affecting 70% of all users. We do not have the resources to fix a bug that affects only 2% of our users and would take a lot of time to figure out. We are always happy to get a PR.

Another one of my bugs ignored.

If you cannot support it, the feature should probably be removed.

Please don't condescendingly give me the gears about a pull request. I already spend A LOT of volunteer time for LimeSurvey.

If you cannot support it, the feature should probably be removed.

Correction : «If you cannot support it, the feature should probably never be added»

I really think sometimes some feature was added without real idea of all work to be done to fix it, improve it and maintain at long term issue …

Adding unit tests is really the only safe way to make sure a feature stays supported.

@galads Interested in fixing this?

Wait sorry, I mean @gabrieljenik, sorry ^^

The ETwigViewRenderer class from yiiext/twig-renderer was already updated by Lime.
Looks like those Lime modifications were lost in some reorganization (May 2021)

Since that is a third-party, we applied the updated back but this time in LSETwigViewRenderer (which extends ETwigViewRenderer) so they don't get lost again.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2360

@tpartner : maybe you can test the commit ?

@gabrieljenik, thanks.

@DenisChenu, the commit fixes the problem in 3.28.18.

It also fixes the problem when I apply it to application/core/LSETwigViewRenderer.php in 5.3.19. Should we open a new bug for that?

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33633

It also fixes the problem when I apply it to application/core/LSETwigViewRenderer.php in 5.3.19. Should we open a new bug for that?

Nope, we will create a new PR.
May ask for your help testing then?

Thanks

@gabrieljenik, of course, no problem.

Fixed in Release 3.28.19+220712

Why is this closed? Was it fixed in 5.x?

It's automatically closed by our release tool if there's a commit phrased like "Fixed issue <bug number>".

Is the issue reported for LS5 too?

Please see the thread above.

capture-3.png (41,595 bytes)   

capture-3.png (41,595 bytes)   

@tpartner: Can I as for your help testing the patch for master?
https://github.com/LimeSurvey/LimeSurvey/pull/2518

Thanks for the help!

@gabrieljenik, sorry for the delay. Tested - all good! Thanks.

Thanks @tpartner !

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=33699

Fixed in Release 5.3.30+220808

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=34757