17685: When adding a new participant, user is able to Save without adding any information and a blank record is save

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

17685	Bug reports	Survey participants (Tokens)	public	2021-10-26 21:18	2022-02-28 12:58

Reporter	gabrieljenik	Assigned To	gabrieljenik
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	5.x

Summary	17685: When adding a new participant, user is able to Save without adding any information and a blank record is save
Description	This happens because there is no validation which fails. The model does not have any required fields, while several fields explicitly accept empty values. That results in empty records being accepted. Adding a new rule doens't sound like a great idea as the impact will be important. I would just add a warning message for managers to confirm they are about to enter a token with no email nor name, nor last name. Detected while reviewing 17572
Steps To Reproduce	Initialize a participants table of a survey. +Create - > +Add participant Do not enter any information, click either Save or Save and close - empty record will be created.
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	5.1.5
I will donate to the project if issue is resolved	No
Browser
Database type & version	n/a
Server OS (if known)
Webserver software & version (if known)
PHP Version	8.x

User List	There are no users monitoring this issue.

DenisChenu 2021-10-27 09:33 developer ~66953	It's really OK for me : since no information is really required : why not accept empty participant. It's not a bug .

galads 2021-10-27 16:36 reporter ~66971 Last edited: 2021-10-27 16:36	Well, there are supposed to be some required fields in my opinion. Just as it is not possible to import a blank CSV file of participants.

gabrieljenik 2021-10-27 16:38 manager ~66972	I would say at least there should be a warning.

DenisChenu 2021-10-27 16:49 developer ~66975	Just as it is not possible to import a blank CSV file of participants. Dummy can create blank partcipant. I know a lot of people filling a CSV file with user1, user2, user3 … only to have lines. There really no reason to disable blank participant :)

gabrieljenik 2021-12-28 13:44 manager ~67865	Added confirmation modal when blank participant is created. PR: https://github.com/LimeSurvey/LimeSurvey/pull/2194

gabrieljenik 2022-02-17 14:12 manager ~68317	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33201

LimeBot 2022-02-28 12:58 administrator ~68430	Fixed in Release 5.3.0+220228

LimeSurvey: master 190dad12 2022-02-17 14:12:12 gabrieljenik Committer: GitHub Details Diff	Fixed issue 17685: When adding a new participant, user is able to Save without adding any information and a blank record is save (#2194) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>	Affected Issues 17685
	mod - application/views/admin/token/tokenform.php	Diff File
	mod - assets/scripts/admin/tokens.js	Diff File

Date Modified	Username	Field	Change
2021-10-26 21:18	gabrieljenik	New Issue
2021-10-26 21:18	gabrieljenik	Issue generated from: 17572
2021-10-26 21:18	gabrieljenik	Relationship added	related to 17572
2021-10-27 09:33	DenisChenu	Note Added: 66953
2021-10-27 09:33	DenisChenu	Bug heat	0 => 2
2021-10-27 16:36	galads	Note Added: 66971
2021-10-27 16:36	galads	Bug heat	2 => 4
2021-10-27 16:36	galads	Assigned To	=> galads
2021-10-27 16:36	galads	Status	new => confirmed
2021-10-27 16:38	gabrieljenik	Note Added: 66972
2021-10-27 16:38	gabrieljenik	Bug heat	4 => 6
2021-10-27 16:49	DenisChenu	Note Added: 66975
2021-12-28 13:44	gabrieljenik	Note Added: 67865
2022-02-17 14:12	gabrieljenik	Changeset attached	=> LimeSurvey master 190dad12
2022-02-17 14:12	gabrieljenik	Note Added: 68317
2022-02-17 14:12	gabrieljenik	Assigned To	galads => gabrieljenik
2022-02-17 14:12	gabrieljenik	Resolution	open => fixed
2022-02-28 12:58	LimeBot	Zoho Project Synchronization	Yes => \|Yes\|
2022-02-28 12:58	LimeBot	Note Added: 68430
2022-02-28 12:58	LimeBot	Status	confirmed => closed
2022-02-28 12:58	LimeBot	Bug heat	6 => 8