Hello, thank you for reporting this issue. Which specific theme does this bug affect?

Or does it happen for all themes?

It happens for all themes (this is why I am not referring to any specific). However, in another installation under Linux (on another machine), this issue does not appear.

Thank you for the information. It seems to be a windows issue because I could also not reproduce in Linux.

I confirmed that the same issue appears with "Skelvanilla" theme too. It is definitely not a theme-dependent issue. If that helps, my tests show that it concerns only images. All other options are saved correctly.

Image or file + windows : this surely check something without DIRECTORY_SEPARATOR when save :)

If Denis is right, can this be solved, please. It is hindering theme development enormously...

I think it also relates to error 17704, since that also occurs on WAMP (Windows) only, it seems.

Is there anyone working on this, please?

Not me : i don't have windows on 5.X

Is there any progress with this bug, please? No one using LimeSurvey on Windows will be able to develop custom themes. Very inconvenient.

error still exists on ver. 5.2.10+220118, is anybody work on it ?

image.png (91,003 bytes)   

image.png (91,003 bytes)   

Dear developer, please look into this. It is a regression from 3.x and I think it will not be very difficult to solve...

Would it perhaps help to offer a donation if the issue is resolved?

Hi,

We are working on it.
It is not an easy fix.

Thanks

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2336

Two problems found.
1) Wrong directory separator being used.
2) A theme can no longer access a file from another theme. But in the config.xml of the base themes, the logo paths were relative to root, instead of being relative to the theme. So when copying, in the extended theme it had a path that was not inside its folder, but in that of another theme, and that is why it was also considered invalid. That should be happening on Linux too, because it has nothing to do with Windows.

@gabrieljenik: Thanks for the reply. This is very interesting and strange because the same problem does not appear in my other installation in Linux.

--> Linux elpida3.it.auth.gr 4.15.0-176-generic #185-Ubuntu SMP Tue Mar 29 17:40:04 UTC 2022 x86_64

Could it be that 1 is the main problem that baltzis and I (and possibly others) encountered and that 2 was not (yet) encountered by us?

@baltzis, Thanks for the reply. This is very interesting and strange because the same problem does not appear in my other installation in Linux.

Can you describe more about the theme and the logo path in the config.xml of it?

tammo, Could it be that 1 is the main problem that baltzis and I (and possibly others) encountered and that 2 was not (yet) encountered by us?

Sure. NUmber 2 should only appear on very specific situations.

@gabrieljenik:

Can you describe more about the theme and the logo path in the config.xml of it?

I am not sure what you are asking for. I am sending the config.xml for extends_bootswatch, as an example. Hopefully, this responds to your request. Please, let me know if you need more information.

For the custom logo to appear, I have to specify the path explicitly in the nav_bar.twig:
{{ image('./files/logo_auth.png', aSurveyInfo.name, {"class": "logo img-responsive"}) }}

If I don't make any changes, the logo does not appear, because in the config.xml the specified file is not saved at all (see the tag <brandlogofile>). In addition, the field "Brandlogo file" in the options of the theme, appears blank, even if I specify the default theme logo (see attached screenshot).

Screenshot 2022-04-12 104548.png (37,060 bytes)   

Screenshot 2022-04-12 104548.png (37,060 bytes)   

<?xml version="1.0" encoding="UTF-8"?>
<!--

    (¯`·._.·(¯`·._.· Bootswatch Theme Manifest  ·._.·´¯)·._.·´¯)

    Base configuration for Vanilla Theme.
    The content of this file is imported into DB when you install the template.

-->
<config>
    <!-- Those metadata are displayed in the theme configuration page.  -->
    <metadata>
        <name>extends_bootswatch</name>
        <title>Bootswatch Theme</title>

        <creationDate/>
        <author>baltzis</author>
        <authorEmail>baltzis@jour.auth.gr</authorEmail>
        <authorUrl>http://www.limesurvey.org</authorUrl>
        <copyright>Copyright (C) 2005 - 2016 LimeSurvey Gmbh, Inc. All rights reserved.</copyright>
        <license>GNU General Public License version 2 or later</license>
        <version>2.0</version>
        <apiVersion>3</apiVersion>
        <description><![CDATA[<strong>LimeSurvey Bootwatch Theme</strong><br>Based on BootsWatch Themes: <a href='https://bootswatch.com/3/'>Visit BootsWatch page</a> ]]></description>
        <last_update>2021-08-30 03:10:07</last_update>
        <extends>bootswatch</extends>
    <lastUpdate>2021-12-06 15:08:54</lastUpdate></metadata>

    <!--
        Here the list of the css/js files to add to the template package.
        About packages in Yii: http://www.yiiframework.com/doc/api/1.1/CClientScript#packages-detail
    -->
    <files>
        <css>
            <add>css/ajaxify.css</add>
            <add>css/theme.css</add>
            <add>css/custom.css</add>
        </css>
        <js>
            <add>scripts/theme.js</add>
            <add>scripts/ajaxify.js</add>
            <add>scripts/custom.js</add>
        </js>
        <print_css>
            <add>css/print_theme.css</add>
        </print_css>
    </files>

    <!-- You can add here any option you want. It will be available in twig file via aSurveyInfo.options.youroptionname -->
    <!-- eg: Ajaxmode: will be available with aSurveyInfo.options.ajaxmode -->
    <options>
        <ajaxmode>on</ajaxmode>
        <brandlogo>on</brandlogo>
        <brandlogofile>./files/logo.png</brandlogofile>
        <container>on</container>
    </options>

    <!-- Here datas about how LimeSurvey should load the theme -->
    

</config>

Couple of questions.
1) On step#2 of your reproduction list, do you upload the logo_auth.png file? If not, when?
2) Does the situation still happens after the patch?

1) In step #2, I uploaded the logo_auth.png after extending the template (it appears on the right side - see screenshot).
2) What is the patch you are referring to? If you mean the change in the nav_bar.twig, the field remains blank, however, the correct logo appears when the survey is tested and activated, and in the preview on the theme editor page as well. This means - of course - that a new template needs to be created for each survey since the custom logo is not saved in "local" survey options either.

1) After uploading it, do you set it as logo on the theme options?
2) I mean this patch: https://github.com/LimeSurvey/LimeSurvey/pull/2336
I understand the correct logo appears when you force it in the twig file.
I was hoping to leave the twig file as it comes from the default theme and use the theme options for setting the logo

As I tried to explain, the logo (ANY logo) is not displayed when set on the theme options. It appears only when forced in the twig file. I forced the logo in the twig file only after I established that LimeSurvey fails to save the path correctly in the theme options.
Concerning the "bootswatch" theme, however, no option selected from any dropdown list is saved on the theme options page whatsoever (variation or logo image). I just tried it again by creating a fresh copy. For other themes (e.g. fruity), this problem appears only for any images (logo, background).

Concerning the patch, I don't understand what you mean. I did not apply any patch, as I don't know how to do this.

Hi Baltiz,

I think the conversation got a little de-railed.
Let's try to pickup.

I mentioned there was an issue that should be happening on both Win and Linux.
You said that on Linux it wasn't reproducible, the bug not appearing.
We started reviewing that.
You are saying the bug appears.
I think we got entangled.

So,my suggestion.
Let's pickup after the PR is merged and check if there are still issues then.

What do you think?

I am saying that the bug appears only on my Windows installation. Everything I have said concerns the Windows installation alone. The installation on Linux works just fine. I never said anything about the bug appearing in Linux and I was very specific about the bug NOT appearing in my Linux installation: see my notes #67804 and #68938 above.

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=33441

Fixed in Release 5.3.12+220502