View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
17971Bug reportsQuestion editorpublic2022-06-01 00:47
ReporterDenisChenu Assigned To 
PrioritynoneSeverityminor 
Status acknowledgedResolutionopen 
Product Version5.2.x 
Summary17971: File upload : deprecated feature : real max upload are not shown
Description

In 3.x : max real upload are shown in help of the settings. It's not the case in 5.X

Steps To Reproduce

Steps to reproduce

Look at max size help on 3.X and 5.X

Expected result

max file size by phpinfo are shown

Actual result

No real situation are shown.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)5
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevantn
PHP Versionnot relevant

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-03-17 13:13

developer  

DenisChenu

DenisChenu

2022-03-17 13:14

developer   ~68718

PS1 : help before inpout is really better than help after input
PS2 : help are not shown for a11y in 5.

gabrieljenik

gabrieljenik

2022-05-04 19:42

manager   ~69394

In LTS the attributes were defined in the questionHelper. Now, they are defined in the XML of each question type.

When you were in the questionHelper (PHP) you could have dynamic content, including system variables. Now the help cannot have dynamic content, because they are in an XML.

This would require adding the capability to include dynamic content in helptext of attributes.
Not rocket sicence, but not very straightforward.

image.png (37,356 bytes)   
image.png (37,356 bytes)   
DenisChenu

DenisChenu

2022-05-04 19:52

developer   ~69396

@gabrieljenik : no need to explain why … i know why …
It's clearly a deprecated feature, and we have user on forum with such issue

About dynamic content : need to think what to add and the way… no php function like here.

We can close it like "Not fixable " too.

gabrieljenik

gabrieljenik

2022-05-04 20:01

manager   ~69398

Last edited: 2022-05-04 20:22

@gabrieljenik : no need to explain why … i know why …

@DenisChenu . OK, now the world als knows. :)
If you know that in advance, please just add it the ticket before hand as it would be helpfull.

We can close it like "Not fixable " too.

I would just lave it for a while

DenisChenu

DenisChenu

2022-05-05 00:34

developer   ~69413

I try to be more clear when i have the solution,
But don't take time to search where all is set in github here

I think it's clear in 2.75 it come from PHP and in 5.X from an XML.

gabrieljenik

gabrieljenik

2022-05-23 14:32

manager   ~69988

For specific question types (or all?), we can:

  • have the twig files to be able to fetch extra variable through specific methods (or hooks)
  • Provide more variables for rendering the "help messages".
  • Have the twig files to do this specific variable replacements

or...

For specific question types (or all?), we can have the twig files to be able to render help messages with specific methods (or hooks) that can do this specific variable replacements.

DenisChenu

DenisChenu

2022-05-23 15:18

developer   ~69993

This one is really tricky … if we have a fix for this one , hope it can be used for QuestionTheme ;)

Issue History

Date Modified Username Field Change
2022-03-17 13:13 DenisChenu New Issue
2022-03-17 13:13 DenisChenu File Added: Capture d’écran du 2022-03-16 16-51-41.png
2022-03-17 13:13 DenisChenu File Added: Capture d’écran du 2022-03-17 13-12-04.png
2022-03-17 13:14 DenisChenu Note Added: 68718
2022-03-17 13:14 DenisChenu Bug heat 0 => 2
2022-05-03 17:21 gabrieljenik Assigned To => gabrieljenik
2022-05-03 17:21 gabrieljenik Status new => assigned
2022-05-04 19:42 gabrieljenik Note Added: 69394
2022-05-04 19:42 gabrieljenik File Added: image.png
2022-05-04 19:42 gabrieljenik Bug heat 2 => 4
2022-05-04 19:52 DenisChenu Note Added: 69396
2022-05-04 20:01 gabrieljenik Note Added: 69398
2022-05-04 20:22 gabrieljenik Note Edited: 69398
2022-05-05 00:34 DenisChenu Note Added: 69413
2022-05-23 14:32 gabrieljenik Note Added: 69988
2022-05-23 14:32 gabrieljenik Status assigned => acknowledged
2022-05-23 14:32 gabrieljenik Assigned To gabrieljenik =>
2022-05-23 15:18 DenisChenu Note Added: 69993
2022-06-01 00:47 gabrieljenik Category Ergonomy => Question editor