View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
18133Bug reportsSurvey editingpublic2022-08-11 20:19
Reporterritapas Assigned ToDenisChenu  
PrioritynormalSeveritypartial_block 
Status ready for code reviewResolutionopen 
Product Version3.28.x 
Summary18133: Set "Other" state has no clue about current state
Description

in the Survey menu - list questions window you can mass change question parameters.
The Set "Other" state always shows the "Other" state as OFF even when it's ON. Is that done on purpose?

Steps To Reproduce

Steps to reproduce

Create survey with at least 2 question groups with at least 2 questions inside. One of those must have "Other" to ON (this applies for instance for List (radio) type.
Go to Settings-Survey menu-  List questions.
Select one question at least, then in the drowpdown choose Set "Other" state

Expected result

I expect to be shown the current "Other" state

Actual result

The Set "Other" state always shows the "Other" state as OFF even when it's ON.

this also happens in limesurvey paas, v. 3.28.11

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)3.28.8 (build 220426)
I will donate to the project if issue is resolvedNo
BrowserMozilla Firefox
Database type & versionphp-mysql-5.4.16
Server OS (if known)Red Hat Enterprise Linux Server release 7.5 (Maipo)
Webserver software & version (if known)httpd-2.4.6-80
PHP Versionrh-php71

Users monitoring this issue

User List ritapas

Activities

ritapas

ritapas

2022-05-19 18:17

reporter  

immagine.png (44,440 bytes)   
immagine.png (44,440 bytes)   
ritapas

ritapas

2022-06-09 13:27

reporter   ~70313

still in 3.28.13 but anyway the setting is applied

gabrieljenik

gabrieljenik

2022-06-14 23:11

manager   ~70365

Will try to reproduce it

gabrieljenik

gabrieljenik

2022-07-21 17:42

manager   ~71085

The issue is that the mass action modal is not aware of the questions being selected.
This can be trickky as if there is a mix of statuses what status should It show?
I think it should always be a dropdown with a "please select" option to avoid confusions.

@c_schmitz? @ollehar?

ollehar

ollehar

2022-07-21 17:44

administrator   ~71086

Can you bring it up in our Cliq channel, please? Easier to follow there.

c_schmitz

c_schmitz

2022-07-22 11:54

administrator   ~71104

Last edited: 2022-07-22 11:56

Yes, this does not seem to be a bug.
Maybe the interface could be made more clear.
Instead of just "Option 'Other'" it could say: " The following state for the question setting 'Other' will be applied to all selected questions:"

Select box is also fine, but need to be set to 'required'.

gabrieljenik

gabrieljenik

2022-07-22 16:12

manager   ~71110

Bug or FR?

gabrieljenik

gabrieljenik

2022-08-09 16:12

manager   ~71390

Last edited: 2022-08-09 16:13

Turning control into a dropdown which doesn't preset any value form the selected items.
PR LTS: https://github.com/LimeSurvey/LimeSurvey/pull/2564

Should we add a warning sign that says something like "this will override the current values on the selected items"?
Also,
Other mass actions may need the same treatment.

gabrieljenik

gabrieljenik

2022-08-11 20:19

manager   ~71417

Master PR: https://github.com/LimeSurvey/LimeSurvey/pull/2568/

Issue History

Date Modified Username Field Change
2022-05-19 18:17 ritapas New Issue
2022-05-19 18:17 ritapas File Added: immagine.png
2022-05-19 18:17 ritapas Issue generated from: 18132
2022-05-19 18:21 ritapas Issue cloned: 18134
2022-05-20 15:55 gabrieljenik Priority none => normal
2022-05-20 15:55 gabrieljenik Severity text => partial_block
2022-06-09 13:27 ritapas Note Added: 70313
2022-06-09 13:27 ritapas Bug heat 0 => 2
2022-06-14 23:11 gabrieljenik Assigned To => gabrieljenik
2022-06-14 23:11 gabrieljenik Status new => acknowledged
2022-06-14 23:11 gabrieljenik Note Added: 70365
2022-06-14 23:11 gabrieljenik Bug heat 2 => 4
2022-06-16 19:04 gabrieljenik Status acknowledged => confirmed
2022-06-16 19:05 gabrieljenik Assigned To gabrieljenik =>
2022-06-22 14:58 ritapas Issue Monitored: ritapas
2022-06-22 14:58 ritapas Bug heat 4 => 6
2022-07-19 20:15 gabrieljenik Assigned To => gabrieljenik
2022-07-19 20:15 gabrieljenik Status confirmed => assigned
2022-07-21 17:42 gabrieljenik Note Added: 71085
2022-07-21 17:44 ollehar Note Added: 71086
2022-07-21 17:44 ollehar Bug heat 6 => 8
2022-07-22 11:54 c_schmitz Note Added: 71104
2022-07-22 11:54 c_schmitz Bug heat 8 => 10
2022-07-22 11:56 c_schmitz Note Edited: 71104
2022-07-22 16:12 gabrieljenik Note Added: 71110
2022-08-09 16:12 gabrieljenik Status assigned => ready for code review
2022-08-09 16:12 gabrieljenik Note Added: 71390
2022-08-09 16:12 gabrieljenik Assigned To gabrieljenik => DenisChenu
2022-08-09 16:13 gabrieljenik Note Edited: 71390
2022-08-11 20:19 gabrieljenik Note Added: 71417