View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
18212Bug reportsLabel setspublic2022-06-24 10:422022-07-27 11:48
Reportertwilllig Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18212: Edit label sets - cannot drag&drop
Description

It is not possible to drag&drop the entries within a label set.

Steps To Reproduce

Steps to reproduce

Import attached label set.
After import go to "View labels" page.
Try to change position via drag&drop

Expected result

rows move and change position

Actual result

nothing happens

TagsNo tags attached.
Attached Files
limesurvey_labelset_1.lsl (2,391 bytes)    
<?xml version="1.0" encoding="UTF-8"?>
<document>
 <LimeSurveyDocType>Label set</LimeSurveyDocType>
 <DBVersion>487</DBVersion>
 <labelsets>
  <fields>
   <fieldname>lid</fieldname>
   <fieldname>label_name</fieldname>
   <fieldname>languages</fieldname>
  </fields>
  <rows>
   <row>
    <lid><![CDATA[1]]></lid>
    <label_name><![CDATA[TestLabelSet]]></label_name>
    <languages><![CDATA[en]]></languages>
   </row>
  </rows>
 </labelsets>
 <labels>
  <fields>
   <fieldname>id</fieldname>
   <fieldname>lid</fieldname>
   <fieldname>code</fieldname>
   <fieldname>sortorder</fieldname>
   <fieldname>assessment_value</fieldname>
  </fields>
  <rows>
   <row>
    <id><![CDATA[13]]></id>
    <lid><![CDATA[1]]></lid>
    <code><![CDATA[L004]]></code>
    <sortorder><![CDATA[2]]></sortorder>
    <assessment_value><![CDATA[2]]></assessment_value>
   </row>
   <row>
    <id><![CDATA[14]]></id>
    <lid><![CDATA[1]]></lid>
    <code><![CDATA[L005]]></code>
    <sortorder><![CDATA[3]]></sortorder>
    <assessment_value><![CDATA[3]]></assessment_value>
   </row>
   <row>
    <id><![CDATA[12]]></id>
    <lid><![CDATA[1]]></lid>
    <code><![CDATA[L003]]></code>
    <sortorder><![CDATA[1]]></sortorder>
    <assessment_value><![CDATA[1]]></assessment_value>
   </row>
   <row>
    <id><![CDATA[11]]></id>
    <lid><![CDATA[1]]></lid>
    <code><![CDATA[L002]]></code>
    <sortorder><![CDATA[0]]></sortorder>
    <assessment_value><![CDATA[0]]></assessment_value>
   </row>
  </rows>
 </labels>
 <label_l10ns>
  <fields>
   <fieldname>id</fieldname>
   <fieldname>label_id</fieldname>
   <fieldname>title</fieldname>
   <fieldname>language</fieldname>
  </fields>
  <rows>
   <row>
    <id><![CDATA[15]]></id>
    <label_id><![CDATA[14]]></label_id>
    <title><![CDATA[totally awesome]]></title>
    <language><![CDATA[en]]></language>
   </row>
   <row>
    <id><![CDATA[13]]></id>
    <label_id><![CDATA[12]]></label_id>
    <title><![CDATA[ok]]></title>
    <language><![CDATA[en]]></language>
   </row>
   <row>
    <id><![CDATA[14]]></id>
    <label_id><![CDATA[13]]></label_id>
    <title><![CDATA[better than ok]]></title>
    <language><![CDATA[en]]></language>
   </row>
   <row>
    <id><![CDATA[12]]></id>
    <label_id><![CDATA[11]]></label_id>
    <title><![CDATA[not good]]></title>
    <language><![CDATA[en]]></language>
   </row>
  </rows>
 </label_l10ns>
</document>
limesurvey_labelset_1.lsl (2,391 bytes)   
labelsets_drag.png (41,443 bytes)   
labelsets_drag.png (41,443 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)Community Edition 5.3.19
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionmySql
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-06-24 17:47

manager   ~70522

Will try to reproduce it
gabrieljenik

gabrieljenik

2022-07-14 21:12

manager   ~70951

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2514
gabrieljenik

gabrieljenik

2022-07-21 14:53

manager   ~71076

Tested OK
DenisChenu

DenisChenu

2022-07-22 09:56

developer   ~71093

Code checked :)
gabrieljenik

gabrieljenik

2022-07-25 18:59

manager   ~71127

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=33680
LimeBot

LimeBot

2022-07-27 11:48

administrator   ~71172

Fixed in Release 5.3.28+220727

Related Changesets

LimeSurvey: master 57deeab3

2022-07-25 16:53:23

gabrieljenik


Committer: GitHub Details Diff 		Fixed issue 18212: Edit label sets - cannot drag&drop (#2514)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>		 Affected Issues
18212
mod - assets/scripts/admin/labels.js Diff File

Issue History

Date Modified Username Field Change
2022-06-24 10:42 twilllig New Issue
2022-06-24 10:42 twilllig File Added: limesurvey_labelset_1.lsl
2022-06-24 10:42 twilllig File Added: labelsets_drag.png
2022-06-24 17:47 gabrieljenik Status new => acknowledged
2022-06-24 17:47 gabrieljenik Note Added: 70522
2022-06-24 17:47 gabrieljenik Bug heat 0 => 2
2022-07-05 14:48 gabrieljenik Status acknowledged => confirmed
2022-07-05 14:49 gabrieljenik Severity minor => partial_block
2022-07-14 01:03 gabrieljenik Assigned To => gabrieljenik
2022-07-14 01:03 gabrieljenik Status confirmed => assigned
2022-07-14 21:12 gabrieljenik Status assigned => ready for code review
2022-07-14 21:12 gabrieljenik Note Added: 70951
2022-07-14 21:19 gabrieljenik Assigned To gabrieljenik => DenisChenu
2022-07-21 14:53 gabrieljenik Note Added: 71076
2022-07-22 09:56 DenisChenu Assigned To DenisChenu =>
2022-07-22 09:56 DenisChenu Status ready for code review => ready for merge
2022-07-22 09:56 DenisChenu Note Added: 71093
2022-07-22 09:56 DenisChenu Bug heat 2 => 4
2022-07-25 18:59 gabrieljenik Changeset attached => LimeSurvey master 57deeab3
2022-07-25 18:59 gabrieljenik Note Added: 71127
2022-07-25 18:59 gabrieljenik Assigned To => gabrieljenik
2022-07-25 18:59 gabrieljenik Resolution open => fixed
2022-07-27 11:48 LimeBot Note Added: 71172
2022-07-27 11:48 LimeBot Status ready for merge => closed
2022-07-27 11:48 LimeBot Bug heat 4 => 6