View Issue Details

This bug affects 1 person(s).
 16
IDProjectCategoryView StatusLast Update
18310Bug reportsSurvey editingpublic2022-12-19 15:22
ReporterJmantysalo Assigned Togabrieljenik  
PrioritynoneSeveritytweak 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18310: Inconsistent GUI: Sort alphabetically vs. random order
Description

Radiobutton-type question has setting "Sort answers alphabetically" with switch On/Off and choise "Random order" with possible values "Yes" and "No". It seems illogical.

Harder question: would it be good if these would be one three-value setting, as one can not have both random order and alphabetic order in the same time? I'm not sure if it would work or not.

TagsNo tags attached.
Bug heat16
Complete LimeSurvey version number (& build)5.3.26+220720
I will donate to the project if issue is resolvedNo
Browser
Database type & versionN/A
Server OS (if known)
Webserver software & version (if known)
PHP VersionN/A

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

tpartner

tpartner

2022-08-15 18:54

partner   ~71440

Last edited: 2022-08-15 19:00

As my comment in the forum - https://forums.limesurvey.org/forum/development/128030-gui-inconsistency-sort-alphabetically-vs-random-order#231158

A 3-way "Answer order" setting with values "Normal", "Random" and "Alphabetic" would be optimum but at the very least it should be indicated that the current settings are exclusive and which takes precedence (seems that random order has precedence).

Jmantysalo

Jmantysalo

2022-09-06 11:29

reporter   ~71606

Our usability specialist also said that this should be a three-valued setting.

tammo

tammo

2022-09-06 15:24

developer   ~71608

Agree and support changing this!

gabrieljenik

gabrieljenik

2022-09-06 15:38

manager   ~71609

Just to double check, which screen are you refrring to?

Options would be:

  • Normal = Alph OFF + Rand OFF
  • Alphabetcially = Alph ON + Rand OFF
  • Random = Alph OFF + Rand ON

Right?

tpartner

tpartner

2022-09-06 19:11

partner   ~71616

@gabrieljenik, it is the list-radio type question but may apply to other types as well.

So, combining "Sort answers alphabetically" (alphasort) and "Random order" (random_order).

Yes, your options are correct.

capture-2.png (40,679 bytes)   
capture-2.png (40,679 bytes)   
Jmantysalo

Jmantysalo

2022-09-07 07:16

reporter   ~71622

gabrieljenik, that is just what I mean.

(In general we should think how to handle setting combinations that are not meaningfull, but that's another story.)

gabrieljenik

gabrieljenik

2022-10-13 18:20

manager   ~72245

WIP: https://github.com/LimeSurvey/LimeSurvey/pull/2666

Thoughts / Open Questions:

  • Does the new attribute is just for questions that has both random & alpha?
    or broader for all that have answer options?
  • Should this go on a minor release or a major one?
Jmantysalo

Jmantysalo

2022-10-24 07:09

reporter   ~72383

You asked

Does the new attribute is just for questions that has both random & alpha? or broader for all that have answer options?

Counter-question: Should there be a question where you can have one but not the other? Can't think an example where that would be meaningful.

gabrieljenik

gabrieljenik

2022-12-12 12:38

manager   ~73064

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34084

gabrieljenik

gabrieljenik

2022-12-12 13:18

manager   ~73065

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34085

kfoster

kfoster

2022-12-12 13:38

developer   ~73066

Tested and merged.

c_schmitz

c_schmitz

2022-12-13 13:19

administrator   ~73082

Documentation also done?

gabrieljenik

gabrieljenik

2022-12-13 14:09

manager   ~73085

Nice catch!

gabrieljenik

gabrieljenik

2022-12-13 14:21

manager   ~73086

OK, this seems to be a lenghty change as there are lot of pages with those attribtes.
We need to:
1 - Remove the random_order attribute page
2 - Remove the Alphasort attribute page
3 - Create a new page for the new attribute
4 - Link it to all the question types related
5 - Handle translations?

Suggestions?

DenisChenu

DenisChenu

2022-12-13 17:58

developer   ~73099

OK, this seems to be a lenghty change as there are lot of pages with those attribtes.

My opinion :

  1. Keep https://manual.limesurvey.org/QS:Random_order but add a https://manual.limesurvey.org/Template:Deprecated (5.14)
  2. Keep https://manual.limesurvey.org/QS:Alphasort but add a https://manual.limesurvey.org/Template:Deprecated (5.14)
  3. Add https://manual.limesurvey.org/QS:answer_order and add a https://manual.limesurvey.org/Template:NewIn in title and a NewFeature in content
LimeBot

LimeBot

2022-12-19 11:00

administrator   ~73179

Fixed in Release 5.5.0+221219

gabrieljenik

gabrieljenik

2022-12-19 14:32

manager   ~73183

Manual updated.

tpartner

tpartner

2022-12-19 15:22

partner   ~73186

Thanks @gabrieljenik.

Related Changesets

LimeSurvey: master 34c0e5e9

2022-12-12 12:38:11

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random (#2666)

* Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random order

- Replace attributes in config.xml for 'L', 'O' and '!' types.

* Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random order

- Handle new attribute in Question::getOrderedAnswers()

* Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random

* Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random

* Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random

* Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Co-authored-by: K Foster <kevin.foster.uk@gmail.com>
Affected Issues
18310

LimeSurvey: master 4e7885ae

2022-12-12 12:38:11

gabrieljenik


Committer: Kevin Foster Details Diff
Fixed issue 18310: Inconsistent GUI: Sort alphabetically vs. random (#2666)

- Replace attributes in config.xml for 'L', 'O' and '!' types.

- Handle new attribute in Question::getOrderedAnswers()

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Co-authored-by: K Foster <kevin.foster.uk@gmail.com>
Affected Issues
18310

LimeSurvey: master 21f8c5fe

2022-12-12 15:56:15

Kevin Foster

Details Diff
Issue 18310 - refactor DB update adding explicit 'AS' Affected Issues
18310
mod - application/helpers/update/updates/Update_492.php Diff File

Issue History

Date Modified Username Field Change
2022-08-15 14:47 Jmantysalo New Issue
2022-08-15 18:54 tpartner Note Added: 71440
2022-08-15 18:54 tpartner Bug heat 0 => 2
2022-08-15 19:00 tpartner Note Edited: 71440
2022-08-16 23:05 gabrieljenik Assigned To => gabrieljenik
2022-08-16 23:05 gabrieljenik Status new => confirmed
2022-09-06 11:29 Jmantysalo Note Added: 71606
2022-09-06 11:29 Jmantysalo Bug heat 2 => 4
2022-09-06 15:24 tammo Note Added: 71608
2022-09-06 15:24 tammo Bug heat 4 => 6
2022-09-06 15:38 gabrieljenik Note Added: 71609
2022-09-06 15:38 gabrieljenik Bug heat 6 => 8
2022-09-06 19:11 tpartner Note Added: 71616
2022-09-06 19:11 tpartner File Added: capture-2.png
2022-09-07 07:16 Jmantysalo Note Added: 71622
2022-10-13 18:20 gabrieljenik Note Added: 72245
2022-10-24 07:09 Jmantysalo Note Added: 72383
2022-11-03 20:23 gabrieljenik Status confirmed => assigned
2022-12-12 12:38 gabrieljenik Changeset attached => LimeSurvey master 34c0e5e9
2022-12-12 12:38 gabrieljenik Note Added: 73064
2022-12-12 12:38 gabrieljenik Resolution open => fixed
2022-12-12 13:18 gabrieljenik Changeset attached => LimeSurvey master 4e7885ae
2022-12-12 13:18 gabrieljenik Note Added: 73065
2022-12-12 13:38 kfoster Status assigned => resolved
2022-12-12 13:38 kfoster Note Added: 73066
2022-12-12 13:38 kfoster Bug heat 8 => 10
2022-12-12 16:10 Changeset attached => LimeSurvey master 21f8c5fe
2022-12-13 13:19 c_schmitz Status resolved => feedback
2022-12-13 13:19 c_schmitz Resolution fixed => reopened
2022-12-13 13:19 c_schmitz Note Added: 73082
2022-12-13 13:19 c_schmitz Bug heat 10 => 12
2022-12-13 14:09 gabrieljenik Note Added: 73085
2022-12-13 14:21 gabrieljenik Note Added: 73086
2022-12-13 17:58 DenisChenu Note Added: 73099
2022-12-13 17:58 DenisChenu Bug heat 12 => 14
2022-12-19 11:00 LimeBot Note Added: 73179
2022-12-19 11:00 LimeBot Status feedback => closed
2022-12-19 11:00 LimeBot Resolution reopened => fixed
2022-12-19 11:00 LimeBot Bug heat 14 => 16
2022-12-19 14:32 gabrieljenik Note Added: 73183
2022-12-19 15:22 tpartner Note Added: 73186