View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
18350Bug reportsRemoteControlpublic2022-09-14 14:522022-09-24 00:00
ReporterSelcal Assigned To 
PrioritynoneSeveritypartial_block 
Status acknowledgedResolutionopen 
Product Version5.3.x 
Summary18350: activate_survey does not correctly set inherited properties for Notification and data management
Description

When using the call activate_survey (which does not accept any options according to the docs), the activated survey does not carry the inherited settings for Notification and Data management. They are all set to NO.
As they cannot be changed once activated, this blocks proper use of the activated survey (for example the Property "SurveyDynamic.datestamp" is not defined error will be displayed if they datestamp option is expected to be yes as inherited).

Activating using the webinterface, these questions are asked in separate dropdowns, presumably setting the options prior to activation. However, I would expect activating a survey would use inherited values without manually having to loop through them to set them manually first?

Steps To Reproduce

Create non activated survey with notification and data management set to Inherit
Set global settings for the notification and data management all to Yes
Use RPC call activate_survey()
Activated survey has all notification and data management set to No (unchangeable).

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)Version 5.3.32+220817
I will donate to the project if issue is resolvedNo
Browser
Database type & version10.3.34-MariaDB-cll-lve - MariaDB Server
Server OS (if known)UNIX
Webserver software & version (if known)Apache
PHP Version7.3

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

Selcal

Selcal

2022-09-14 14:58

reporter   ~71742

In fact, manually looking at the settings, they are all copied as value 'I', which is indeed a simple copy.
The non-changeable settings though, seem to require the actual setting which should be set at activation time to the value to be interited?
ollehar

ollehar

2022-09-15 11:15

administrator   ~71757

Feel free to do a pull request.
Selcal

Selcal

2022-09-15 19:38

reporter   ~71777

I would, if I felt anywhere near comfortable to safely make this adjustment in the LS code. I do not.

As it stands, AFAIK, using Remove control, I cannot use a get call to see what the inheritable settings are (doing get_survey_properties on the survey returns 'inherit', and the settings are not in the get_global settings).
So with remote control I can't get further than to manually set the survey settings prior to activation, to settings that are fixed and not related to the actual configured settings to be inherited.

Without that workaround, activating a survey using Remote Control breaks the activated survey and my intend was to inform you of this. It is not intended to suggest anyone is obliged to fix this, and if I could do it myself (without surely breaking functionality or stability of the code), I would. Sorry about that.

Issue History

Date Modified Username Field Change
2022-09-14 14:52 Selcal New Issue
2022-09-14 14:58 Selcal Note Added: 71742
2022-09-14 14:58 Selcal Bug heat 0 => 2
2022-09-15 11:15 ollehar Note Added: 71757
2022-09-15 11:15 ollehar Bug heat 2 => 4
2022-09-15 19:38 Selcal Note Added: 71777
2022-09-24 00:00 gabrieljenik Status new => acknowledged