View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
18439Bug reportsAuthenticationpublic2023-10-16 08:41
ReporterDenisChenu Assigned Togabrieljenik  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version5.4.x 
Fixed in Version5.6.x 
Summary18439: Link set when create user are unusuable in text view
Description

LOGINURL to set url are not shown in text view

Steps To Reproduce

Steps to reproduce

Set your mail reader to use only text email
Create an user with your email
Receive the email
Search for the link

Expected result

Have the link somewhere (after Click here to set your password in parenthesis for example)

Actual result

No link to click

TagsNo tags attached.
Attached Files
Bug heat10
Complete LimeSurvey version number (& build)5.4.8
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-10-31 15:41

developer   ~72492

On https://www.chuggnutt.com/html2text

Links are preserved as a footnoted list at the end

It can be great, but don't seems to work here ?

gabrieljenik

gabrieljenik

2023-08-08 14:34

manager   ~76491

Altbody was never set as phpMailer always set it based on the original body.
Hence, the custom "alt-body creation" was not applied. This last was fixed.

v5 https://github.com/LimeSurvey/LimeSurvey/pull/3335

gabrieljenik

gabrieljenik

2023-08-08 14:34

manager   ~76492

This is to review and maybe to create a new ticket:
https://github.com/LimeSurvey/LimeSurvey/pull/3335/files#diff-2a7c4def4e0208ae2ab6f4156f43ea01aafcca9f507de5f52675bbbc022a0c24R591

DenisChenu

DenisChenu

2023-09-08 16:02

developer   ~76922

Extend directly https://github.com/LimeSurvey/LimeSurvey/blob/898dec3ad68a0186f815eed8c5f6dd2ca7f4e4eb/vendor/phpmailer/phpmailer/src/PHPMailer.php#L4387C21-L4387C30 ?

:)

tibor.pacalat

tibor.pacalat

2023-09-26 14:35

administrator   ~77331

@gabrieljenik the link should omit the last bracket, otherwise I get error message when clicking on the link "The validation key is invalid. Please contact the administrator." (image1)

This fix is also needed for master!

image1.png (25,441 bytes)   
image1.png (25,441 bytes)   
DenisChenu

DenisChenu

2023-09-26 15:55

developer   ~77335

the link should omit the last bracket, otherwise I get error message when clicking on the link "The validation key is invalid. Please contact the administrator." (image1)

More an issue in your email reader, no ?

gabrieljenik

gabrieljenik

2023-09-27 14:18

manager   ~77371

@gabrieljenik the link should omit the last bracket, otherwise I get error message when clicking on the link "The validation key is invalid. Please contact the administrator." (image1)

Yes, I think so.
Can you please attach the email message or the raw message?

tibor.pacalat

tibor.pacalat

2023-09-27 14:41

administrator   ~77373

I think this is fine, because in raw message I see this:
...
Click here to set your password
[http://ls-ce-5x/index.php?r=admin/authentication/sa/newPassword/param/nadk4k9c3ksvipyqjgsryuh8htmkqtr28xcc4e]

If you have any questions regarding this email, please do not hesitate
to contact the site administrator at your-email@example.net.
...

guest

guest

2023-09-27 14:45

viewer   ~77374

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35556

guest

guest

2023-09-27 14:45

viewer   ~77375

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35555

LimeBot

LimeBot

2023-10-04 11:30

administrator   ~77502

Fixed in Release 5.6.40+231005

DenisChenu

DenisChenu

2023-10-04 11:54

developer   ~77504

master ?

gabrieljenik

gabrieljenik

2023-10-04 19:47

manager   ~77510

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3510

tibor.pacalat

tibor.pacalat

2023-10-05 12:18

administrator   ~77517

I tested fix for master and it works as intended.

guest

guest

2023-10-07 12:35

viewer   ~77556

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35589

guest

guest

2023-10-07 12:35

viewer   ~77557

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35588

DenisChenu

DenisChenu

2023-10-07 12:36

developer   ~77558

5X and master

LimeBot

LimeBot

2023-10-16 08:41

administrator   ~77724

Fixed in Release 6.3.0+231016

Related Changesets

LimeSurvey: 5.x b68f375f

2023-09-27 14:43:12

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 18439: Link set when create user are unusuable in text view (#3335)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18439
mod - application/core/LimeMailer.php Diff File

LimeSurvey: 5.x b68f375f

2023-09-27 14:43:12

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 18439: Link set when create user are unusuable in text view (#3335)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
18439
mod - application/core/LimeMailer.php Diff File

LimeSurvey: master feacfd96

2023-10-07 12:35:30

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 18439: Link set when create user are unusuable in text view (#3510)

Dev: hanges ported from https://github.com/LimeSurvey/LimeSurvey/pull/3335/files
Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18439
mod - application/core/LimeMailer.php Diff File

LimeSurvey: master feacfd96

2023-10-07 12:35:30

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 18439: Link set when create user are unusuable in text view (#3510)

Dev: hanges ported from https://github.com/LimeSurvey/LimeSurvey/pull/3335/files
Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18439
mod - application/core/LimeMailer.php Diff File

Issue History

Date Modified Username Field Change
2022-10-31 15:37 DenisChenu New Issue
2022-10-31 15:37 DenisChenu File Added: Capture d’écran du 2022-10-31 15-34-50.png
2022-10-31 15:41 DenisChenu Note Added: 72492
2022-10-31 15:41 DenisChenu Bug heat 0 => 2
2022-11-01 09:23 ollehar Priority none => normal
2023-01-19 13:43 gabrieljenik Status new => confirmed
2023-08-08 14:34 gabrieljenik Assigned To => DenisChenu
2023-08-08 14:34 gabrieljenik Status confirmed => ready for code review
2023-08-08 14:34 gabrieljenik Note Added: 76491
2023-08-08 14:34 gabrieljenik Bug heat 2 => 4
2023-08-08 14:34 gabrieljenik Note Added: 76492
2023-09-08 16:02 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-09-08 16:02 DenisChenu Status ready for code review => in code review
2023-09-08 16:02 DenisChenu Note Added: 76922
2023-09-25 20:20 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-09-25 20:20 gabrieljenik Status in code review => ready for merge
2023-09-26 14:35 tibor.pacalat Note Added: 77331
2023-09-26 14:35 tibor.pacalat File Added: image1.png
2023-09-26 14:35 tibor.pacalat Bug heat 4 => 6
2023-09-26 14:36 tibor.pacalat Assigned To tibor.pacalat => gabrieljenik
2023-09-26 15:55 DenisChenu Note Added: 77335
2023-09-27 14:18 gabrieljenik Note Added: 77371
2023-09-27 14:41 tibor.pacalat Note Added: 77373
2023-09-27 14:45 Changeset attached => LimeSurvey 5.x b68f375f
2023-09-27 14:45 Changeset attached => LimeSurvey 5.x b68f375f
2023-09-27 14:45 guest Note Added: 77374
2023-09-27 14:45 guest Note Added: 77375
2023-09-27 14:45 guest Bug heat 6 => 8
2023-09-27 14:45 guest Bug heat 6 => 8
2023-10-04 11:30 LimeBot Note Added: 77502
2023-10-04 11:30 LimeBot Status ready for merge => closed
2023-10-04 11:30 LimeBot Resolution open => fixed
2023-10-04 11:30 LimeBot Bug heat 8 => 10
2023-10-04 11:54 DenisChenu Note Added: 77504
2023-10-04 19:47 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-10-04 19:47 gabrieljenik Status closed => ready for code review
2023-10-04 19:47 gabrieljenik Note Added: 77510
2023-10-05 12:18 tibor.pacalat Note Added: 77517
2023-10-07 12:35 Changeset attached => LimeSurvey master feacfd96
2023-10-07 12:35 guest Note Added: 77556
2023-10-07 12:35 Changeset attached => LimeSurvey master feacfd96
2023-10-07 12:35 guest Note Added: 77557
2023-10-07 12:36 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-10-07 12:36 DenisChenu Status ready for code review => resolved
2023-10-07 12:36 DenisChenu Fixed in Version => 5.6.x
2023-10-07 12:36 DenisChenu Note Added: 77558
2023-10-16 08:41 LimeBot Note Added: 77724
2023-10-16 08:41 LimeBot Status resolved => closed