View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18464 | Bug reports | Plugins | public | 2022-11-06 16:59 | 2023-05-19 13:37 |
Reporter | bartoszm85 | Assigned To | DenisChenu | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.4.x | ||||
Summary | 18464: Min/max settings doesn't work for question attribute with type of integer | ||||
Description | The plugin can add its own question attributes. If I add the question attribute with integer type, it doesn't recognize min/max settings and in the HTML generated view I can set the value beyond min/max. Min/max settings work for simple plugins settings but not for plugin question attributes. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | 5.3.x & 5.4.x | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | doesn't matter | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | doesn't matter | ||||
@DenisChenu something for you? |
|
Unsure ? I hate the new way of QuetsionAttribute system. Else : sorry : this week a lot of work for client, some time delay. I take a look this afternoon. |
|
@bartoszm85 can you send a sample plugin please ? Just with a test settings, no need a working plugin. |
|
Not related to plugins See file_upload question type |
|
|
|
???????????????????? |
|
Hmm, validation is off here. I managed to input max:1 and min:4 and successfully create question (file upload type). |
|
thee are no control like that , we only have min=1 for max file : https://github.com/LimeSurvey/LimeSurvey/blob/5482c09efa9a2be724fe7d76f6a577f070919909/application/views/survey/questions/answer/file_upload/config.xml#L181 We don't have other control. and
|
|
Please take a look at the video, this is when using bugs/18464_minmax_questionattribute. |
|
Yes and ? It's not the issue here … The minimal valus set for max file is set to 1, but you can set to -1 if you want. There are NO other restriction then |
|
The issue was only for the settings set currently in config.xml In 3.X : we can set min/max and the Administrator can not enter a different value. |
|
Then : in current version : you can enter -1 and -1 (on forum : someone enter 0, it's the reason i see the issue) |
|
But you do realise that this doesn't make sense - to be able to set min > max? I see what you mean and what you fixed, but I think, since you already touched this part of code, that this extra validation makes sense as well. |
|
No, config.xml are fixed, there are no way to use another settings in current config.xml system.
In 3.X : you can not set -1, in 5.X and 6.X : you can set -1. I only fix this issue … Another issue was User can set min_files > max_files in upload question type This is totally another issue here … ping @ollehar |
|
@tibor.pacalat : you say to Gabriel on https://bugs.limesurvey.org/view.php?id=18495#c75099 «if the system wasn't designed to support this, this is clearly a feature request. Otherwise, it is a bug.» The Question advanced settings system are NOT designed to allow to control min_files <= max_files |
|
@DenisChenu thanks for your feedback, I agree with the things you pointed out. |
|
Merged. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34697 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34698 |
|
LimeSurvey: master 2dd4f5c0 2023-05-19 13:07:49 Committer: GitHub Details Diff |
Fixed issue 18464: Min/max settings doesn't work for question attrib… (#2708) * Fixed issue 18464: Min/max settings doesn't work for question attribute with type of integer Dev: add the HTML attribute (clearly removed from code) * Dev: add minimal comment |
Affected Issues 18464 |
|
mod - application/extensions/AdvancedSettingWidget/views/integer.php | Diff File | ||
mod - application/models/QuestionAttribute.php | Diff File | ||
LimeSurvey: master 2dd4f5c0 2023-05-19 13:07:49 Committer: GitHub Details Diff |
Fixed issue 18464: Min/max settings doesn't work for question attrib… (#2708) * Fixed issue 18464: Min/max settings doesn't work for question attribute with type of integer Dev: add the HTML attribute (clearly removed from code) * Dev: add minimal comment |
Affected Issues 18464 |
|
mod - application/extensions/AdvancedSettingWidget/views/integer.php | Diff File | ||
mod - application/models/QuestionAttribute.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-11-06 16:59 | bartoszm85 | New Issue | |
2022-11-07 11:41 | ollehar | Priority | none => normal |
2022-11-07 11:41 | ollehar | Note Added: 72589 | |
2022-11-07 11:41 | ollehar | Bug heat | 0 => 2 |
2022-11-07 11:43 | DenisChenu | Note Added: 72592 | |
2022-11-07 11:43 | DenisChenu | Bug heat | 2 => 4 |
2022-11-07 11:44 | DenisChenu | Note Added: 72593 | |
2022-11-07 11:44 | DenisChenu | Assigned To | => DenisChenu |
2022-11-07 11:44 | DenisChenu | Status | new => feedback |
2022-11-08 12:11 | DenisChenu | Status | feedback => confirmed |
2022-11-08 12:11 | DenisChenu | Note Added: 72629 | |
2022-11-08 12:11 | DenisChenu | Note Added: 72630 | |
2022-11-08 12:11 | DenisChenu | File Added: Capture d’écran du 2022-11-08 12-11-10.png | |
2022-11-08 12:12 | DenisChenu | Status | confirmed => assigned |
2022-11-08 12:36 | DenisChenu | Note Added: 72632 | |
2022-11-08 12:36 | DenisChenu | Summary | Min/max settings doesn't work for plugin added question attribute with type of integer => Min/max settings doesn't work for question attribute with type of integer |
2022-11-08 12:47 | DenisChenu | Assigned To | DenisChenu => |
2022-11-08 12:47 | DenisChenu | Status | assigned => ready for code review |
2022-11-08 12:48 | DenisChenu | Issue Monitored: DenisChenu | |
2022-11-08 12:48 | DenisChenu | Bug heat | 4 => 6 |
2022-11-08 12:48 | DenisChenu | Note Added: 72633 | |
2023-02-16 17:39 | gabrieljenik | Status | ready for code review => ready for testing |
2023-05-17 15:52 | tibor.pacalat | Note Added: 75035 | |
2023-05-17 15:52 | tibor.pacalat | Bug heat | 6 => 8 |
2023-05-17 16:42 | DenisChenu | Note Added: 75037 | |
2023-05-17 17:00 | tibor.pacalat | Note Added: 75038 | |
2023-05-17 17:00 | tibor.pacalat | File Added: Screen-2023-05-17-165902.mp4 | |
2023-05-17 17:02 | DenisChenu | Note Added: 75039 | |
2023-05-17 17:20 | DenisChenu | Note Added: 75041 | |
2023-05-17 17:20 | DenisChenu | File Added: minmax-3X-OK.gif | |
2023-05-17 17:20 | DenisChenu | File Added: minmax-5X-issue.gif | |
2023-05-17 17:20 | DenisChenu | Note Added: 75042 | |
2023-05-17 17:21 | DenisChenu | Note Edited: 75042 | |
2023-05-19 11:48 | tibor.pacalat | Note Added: 75100 | |
2023-05-19 11:58 | DenisChenu | Note Added: 75101 | |
2023-05-19 12:01 | DenisChenu | Note Added: 75102 | |
2023-05-19 12:22 | tibor.pacalat | Note Added: 75105 | |
2023-05-19 13:08 | tibor.pacalat | Assigned To | => tibor.pacalat |
2023-05-19 13:08 | tibor.pacalat | Status | ready for testing => closed |
2023-05-19 13:08 | tibor.pacalat | Resolution | open => fixed |
2023-05-19 13:08 | tibor.pacalat | Note Added: 75109 | |
2023-05-19 13:37 | DenisChenu | Changeset attached | => LimeSurvey master 2dd4f5c0 |
2023-05-19 13:37 | DenisChenu | Note Added: 75111 | |
2023-05-19 13:37 | DenisChenu | Changeset attached | => LimeSurvey master 2dd4f5c0 |
2023-05-19 13:37 | DenisChenu | Note Added: 75112 | |
2023-05-19 13:37 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2023-05-19 13:37 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |