View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
18548Bug reportsQuestion editorpublic2023-06-20 17:49
ReporterxxJJxx Assigned Toollehar  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.4.x 
Summary18548: Quick add function "Code ; Title" doesn't work.
Description

When I enter "CODE;Title" in the Quick add Window, only the "CODE" is written in the title field. The original code "AO01" remains.

Steps To Reproduce

An example, the original code is "AO01" Title is empty. In the Quick Add window I enter A23;Test and confirm or replace it. It is only written in the "A23" title and the code column remains "AO01" and the title "Test" has completely disappeared.

TagsNo tags attached.
Attached Files
LS_QuickAdd.jpg (39,755 bytes)   
LS_QuickAdd.jpg (39,755 bytes)   
LS_QuickAdd_2.jpg (24,905 bytes)   
LS_QuickAdd_2.jpg (24,905 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)5.4.4+221004
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMicrosoft SQL / MSSQL
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4.27

Relationships

related to 18628 closedollehar Answer Code updates on base language are not reflected on secondary languages. 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2022-12-09 15:44

developer   ~73045

Last edited: 2022-12-09 15:44

I can not reproduce on firefox 107,
browser dependent maybe ?

Peek 09-12-2022 15-43.gif (430,332 bytes)
xxJJxx

xxJJxx

2022-12-12 10:39

reporter   ~73051

Hello @DenisChenu and thanks for the video/gif. I forgot to mention that I set 3 languages. With only one language it works as it should. Unfortunately, it doesn't work with multiple languages. I have now found out that the code only has to be written once and then the number of titles in as many languages ​​as there are. An example: Code 9999;TestLang1;TestLang2;TestLang3 Then I have the division into the three languages, but the code is only correct for the first language, the other two languages ​​both get the code 855 as an example, although I have 9999 have specified. Thank you an Best Regards

DenisChenu

DenisChenu

2022-12-12 10:45

developer   ~73052

With multiple : language if i don't make error you need to use one column for each language

In your sample (and 3 language) can you try

20;Andora;Andora:Andora
21;Albania;Albania:Albania

For 20;Andora using 20 for code and Andora for ALL language : maybe need a feature request ?

xxJJxx

xxJJxx

2022-12-12 11:46

reporter   ~73054

Thank you, exactly as you say, one column must be taken for each language and separated with a semicolon or tab. In your example, the separator in the last column was a colon, but I corrected it and the result is unfortunately incorrect, as in my test. The code is only used for the first language, the other two languages ​​receive a consecutive code of the original code. I'll add a few more pictures. Should I open a new case for this?

DenisChenu

DenisChenu

2022-12-12 12:14

developer   ~73058

Can you just save it after ?

The Code of 2nd and 3rd language are updated only after save : maybe the issue is here ?

I don't think you need to report another issue.

xxJJxx

xxJJxx

2022-12-12 12:23

reporter   ~73061

Ohhhh no, sorry, that's my fault I didn't save as I thought it wasn't correct. Unfortunately, it is not easy to see that the codes are only accepted after they have been saved. Maybe that should be mentioned in the manual? Thank you for your great support and patience. Kind regards to you

DenisChenu

DenisChenu

2022-12-12 12:28

developer   ~73063

My opinion

  1. Must have a help inside the GUI for multilingal survey
  2. Must link to a manual page

Have a one value update can be cool too, unsure it's a Feature Request or not.

gabrieljenik

gabrieljenik

2022-12-13 19:08

manager   ~73103

Agree.

@xxJJxx what do you think the text in the popup should be like? Can you help us there?

xxJJxx

xxJJxx

2022-12-14 08:44

reporter   ~73112

@gabrieljenik Something like that: Please save the question to apply the answer codes to the other languages.

Or: You must save the questions so that the answer codes are applied to the other languages.

xxJJxx

xxJJxx

2022-12-14 08:45

reporter   ~73113

In German:

Bitte speichern Sie die Frage, um die Antwortcodes auf die anderen Sprachen anzuwenden.

Sie müssen die Fragen speichern, damit die Antwortcodes für die anderen Sprachen übernommen werden.

gabrieljenik

gabrieljenik

2022-12-14 13:11

manager   ~73118

Or: You must save the questions so that the answer codes are applied to the other languages.

What about this?
Please remember to save the question after the options are applied.

(it doesn't matter if the survey is multi language or not)

DenisChenu

DenisChenu

2022-12-14 13:50

developer   ~73119

Last edited: 2022-12-14 13:51

Seems we have a worst issue in last version

  • Update code
  • adding answers

See screencast

It's not updated even after save …

gabrieljenik

gabrieljenik

2022-12-14 17:12

manager   ~73120

I would say is a different ticket

DenisChenu

DenisChenu

2022-12-14 17:37

developer   ~73121

Yes :)
Sure :)

I just think we have same issue (code are not updated before save) then : same ticket … but when testing … all seem broken.

xxJJxx

xxJJxx

2022-12-20 15:22

reporter   ~73212

Hello, please excuse my late reply. Should I check something else now or is there still something to do from my side?

I also noticed that the comfort update no longer works, no connection to the server after the comfort update itself was updated.

comfort Update.jpg (48,248 bytes)   
comfort Update.jpg (48,248 bytes)   
gabrieljenik

gabrieljenik

2023-01-27 13:09

manager   ~73592

Seems we have a worst issue in last version

@DenisChenu, created 18609 for it.

I also noticed that the comfort update no longer works, no connection to the server after the comfort update itself was updated.

I am sorry. Best is to create another ticket or contact support for this matter, as to not mix subjects.

gabrieljenik

gabrieljenik

2023-02-06 16:01

manager   ~73700

Last edited: 2023-02-06 16:02

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2892

Message in quick add popup added. “Please recall to use the save button after applying the changes”

DenisChenu

DenisChenu

2023-02-08 10:49

developer   ~73727

Message in quick add popup added. “Please recall to use the save button after applying the changes”

The real fix are trigger update of other text after updating a code (with JS).

Here : is it really a fix ?

gabrieljenik

gabrieljenik

2023-02-08 15:24

manager   ~73732

Last edited: 2023-02-08 15:28

xxjjxx said here https://bugs.limesurvey.org/view.php?id=18548#c73061:

Ohhhh no, sorry, that's my fault I didn't save as I thought it wasn't correct. Unfortunately, it is not easy to see that the codes are only accepted after they have been saved. Maybe that should be mentioned in the manual? Thank you for your great support and patience. Kind regards to you

Then you said:

Must have a help inside the GUI for multilingal survey

Then, we updated the GUI.

Later you said:

The real fix are trigger update of other text after updating a code (with JS).

I am not sure about the implications. Agree would be better than asking people to save it.

Also you said when uploading the video:

It's not updated even after save …

I believe it is a different issue and a different ticket.
Maybe same cause. But still, easier to handle it and test it separately

guest

guest

2023-02-17 14:55

viewer   ~73876

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34321

Related Changesets

LimeSurvey: master 5bf664ce

2023-02-17 14:54:55

Gabriel Jenik


Committer: GitHub Details Diff
Fixed Issue 18548: Quick add function "Code ; Title" doesn't work. (#2892)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>
Affected Issues
18548
mod - application/views/questionAdministration/modals.twig Diff File

Issue History

Date Modified Username Field Change
2022-12-09 15:40 xxJJxx New Issue
2022-12-09 15:40 xxJJxx File Added: LS_QuickAdd.jpg
2022-12-09 15:40 xxJJxx File Added: LS_QuickAdd_2.jpg
2022-12-09 15:44 DenisChenu Note Added: 73045
2022-12-09 15:44 DenisChenu File Added: Peek 09-12-2022 15-43.gif
2022-12-09 15:44 DenisChenu Bug heat 0 => 2
2022-12-09 15:44 DenisChenu Note Edited: 73045
2022-12-12 10:39 xxJJxx Note Added: 73051
2022-12-12 10:39 xxJJxx Bug heat 2 => 4
2022-12-12 10:45 DenisChenu Note Added: 73052
2022-12-12 11:46 xxJJxx Note Added: 73054
2022-12-12 11:46 xxJJxx File Added: Screenshot 2022-12-12 113752.jpg
2022-12-12 11:46 xxJJxx File Added: Screenshot 2022-12-12 113813.jpg
2022-12-12 11:46 xxJJxx File Added: Screenshot 2022-12-12 114048.jpg
2022-12-12 12:14 DenisChenu Note Added: 73058
2022-12-12 12:23 xxJJxx Note Added: 73061
2022-12-12 12:28 DenisChenu Note Added: 73063
2022-12-13 19:08 gabrieljenik Note Added: 73103
2022-12-13 19:08 gabrieljenik Bug heat 4 => 6
2022-12-13 19:09 gabrieljenik Status new => acknowledged
2022-12-14 08:44 xxJJxx Note Added: 73112
2022-12-14 08:45 xxJJxx Note Added: 73113
2022-12-14 13:11 gabrieljenik Note Added: 73118
2022-12-14 13:50 DenisChenu Note Added: 73119
2022-12-14 13:50 DenisChenu File Added: Peek 14-12-2022 13-49.mp4
2022-12-14 13:51 DenisChenu Note Edited: 73119
2022-12-14 17:12 gabrieljenik Note Added: 73120
2022-12-14 17:37 DenisChenu Note Added: 73121
2022-12-20 15:22 xxJJxx Note Added: 73212
2022-12-20 15:22 xxJJxx File Added: comfort Update.jpg
2023-01-27 13:00 gabrieljenik Issue cloned: 18609
2023-01-27 13:07 gabrieljenik Assigned To => gabrieljenik
2023-01-27 13:07 gabrieljenik Status acknowledged => assigned
2023-01-27 13:09 gabrieljenik Note Added: 73592
2023-02-06 16:01 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-02-06 16:01 gabrieljenik Status assigned => ready for code review
2023-02-06 16:01 gabrieljenik Note Added: 73700
2023-02-06 16:02 gabrieljenik Note Edited: 73700
2023-02-08 10:49 DenisChenu Note Added: 73727
2023-02-08 15:24 gabrieljenik Note Added: 73732
2023-02-08 15:26 gabrieljenik Note Edited: 73732
2023-02-08 15:28 gabrieljenik Note Edited: 73732
2023-02-08 15:30 gabrieljenik Issue cloned: 18628
2023-02-08 15:30 gabrieljenik Relationship added related to 18628
2023-02-09 08:11 DenisChenu Assigned To DenisChenu =>
2023-02-09 08:11 DenisChenu Status ready for code review => ready for testing
2023-02-15 14:26 gabrieljenik Assigned To => ollehar
2023-02-15 14:26 gabrieljenik Status ready for testing => ready for merge
2023-02-17 14:55 Changeset attached => LimeSurvey master 5bf664ce
2023-02-17 14:55 guest Note Added: 73876
2023-02-17 14:55 guest Bug heat 6 => 8
2023-02-21 14:43 ollehar Status ready for merge => resolved
2023-02-21 14:43 ollehar Resolution open => fixed
2023-06-20 17:49 c_schmitz Status resolved => closed