View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
18596Bug reportsOtherpublic2023-01-16 14:452023-10-13 15:39
Reporterollehar Assigned Toollehar  
PriorityhighSeverityminor 
Status resolvedResolutionfixed 
Summary18596: Reintroduce lost unit tests from merge
Description

testGetAvailableSiteSettings
testExportResponses

These two tests overlap during merge, making it impossible to figure out what's what. Should be possible to copy paste. Feel free to add new files instead, to avoid merge conflicts in the future.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)develop
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2023-01-16 16:42

manager   ~73475

This is on DEV, right?
Port those test from master to dev, right?
ollehar

ollehar

2023-01-19 10:55

administrator   ~73495

Not even port, just copy-paste the lost code. Or move it to separate test class, yeah.
gabrieljenik

gabrieljenik

2023-01-24 19:01

manager   ~73547

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2867
tibor.pacalat

tibor.pacalat

2023-10-13 15:38

administrator   ~77704

This has already been merged.

Related Changesets

LimeSurvey: master 6d7c3b21

2023-01-26 10:18:45

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed issue 18596: Reintroduce lost unit tests from merge (#2867)

Co-authored-by: Lapiu Dev <victor3790@gmail.com>
Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18596
add - tests/unit/helpers/RemoteControlExportResponsesTest.php Diff File
add - tests/unit/helpers/RemoteControlGetAvailableSiteSettingsTest.php Diff File
mod - tests/unit/helpers/RemoteControlTest.php Diff File

Issue History

Date Modified Username Field Change
2023-01-16 14:45 ollehar New Issue
2023-01-16 14:45 ollehar Description Updated
2023-01-16 14:46 ollehar Assigned To => gabrieljenik
2023-01-16 14:46 ollehar Priority none => high
2023-01-16 14:46 ollehar Status new => assigned
2023-01-16 16:42 gabrieljenik Note Added: 73475
2023-01-16 16:42 gabrieljenik Bug heat 0 => 2
2023-01-19 10:55 ollehar Note Added: 73495
2023-01-19 10:55 ollehar Bug heat 2 => 4
2023-01-24 19:01 gabrieljenik Assigned To gabrieljenik => ollehar
2023-01-24 19:01 gabrieljenik Status assigned => ready for code review
2023-01-24 19:01 gabrieljenik Note Added: 73547
2023-07-17 18:07 Changeset attached => LimeSurvey master 6d7c3b21
2023-10-13 15:38 tibor.pacalat Status ready for code review => closed
2023-10-13 15:38 tibor.pacalat Resolution open => fixed
2023-10-13 15:38 tibor.pacalat Note Added: 77704
2023-10-13 15:38 tibor.pacalat Bug heat 4 => 6
2023-10-13 15:39 tibor.pacalat Status closed => resolved