View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
18911Bug reportsTheme editorpublic2023-06-23 09:442023-08-31 19:20
Reporterritapas Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status resolvedResolutionfixed 
Product Version3.28.x 
Summary18911: import of theme fails if it contains resource with uppercase extension (LS3, LS5)
Description

If you import a theme containing a resource file named <whatever>.PNG the file is skipped-

Tested with LS 3.28.54 and LS 5.4.14

if you rename same file as *.png (lowercase) inside the zip file, it works.

Problem is, the Windows capture tool as a default saves its capture as .PNG and not png

Steps To Reproduce

Steps to reproduce

Install enclosed theme

Expected result

Import successful

Actual result

Import theme result:

Partial
Skipped files:

File: files/foobar.PNG
TagsNo tags attached.
Attached Files
testExtBug_v2.zip (137,029 bytes)
Bug heat10
Complete LimeSurvey version number (& build)LS 5.4.14 (build 221205), LS 3.28.54 (the PAAS version)
I will donate to the project if issue is resolvedNo
Browser
Database type & versionn/a
Server OS (if known)
Webserver software & version (if known)
PHP Versionn/a

Relationships

Relationship GraphDependency Graph
related to 19067 confirmed Participant uploads fails if it contains resource with uppercase extension (LS3, LS5) 

Users monitoring this issue

ritapas

Activities

DenisChenu

DenisChenu

2023-06-23 09:57

developer   ~75814

Yes, check if allowed in lowercase must be done.

I update the title for this information.
DenisChenu

DenisChenu

2023-06-23 09:59

developer   ~75815

If i don't make error : we use case incentivize comparison in Upload files question type and in Upload survey file ?
ritapas

ritapas

2023-06-23 10:18

reporter   ~75816

If you are asking me sorry, I don't know.
gabrieljenik

gabrieljenik

2023-08-18 15:02

manager   ~76644

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3373
DenisChenu

DenisChenu

2023-08-30 11:58

developer   ~76781

@gabrieljenik : i think it's best if you don'tb rfename it.

See : https://github.com/LimeSurvey/LimeSurvey/blob/6ad5917fc5a9c7355588d895e68cb2ed8bffef09/application/controllers/UploaderController.php#L181

Maybe need to lowercase the list too.
gabrieljenik

gabrieljenik

2023-08-30 16:04

manager   ~76790

@gabrieljenik : i think it's best if you don'tb rfename it.

The most common is to have it lowercase, right? That will bring more order and minimize errors.

See : https://github.com/LimeSurvey/LimeSurvey/blob/6ad5917fc5a9c7355588d895e68cb2ed8bffef09/application/controllers/UploaderController.php#L181
Maybe need to lowercase the list too.

I think we should add a different ticket for that. Similar situation maybe, but on survey taking side.
DenisChenu

DenisChenu

2023-08-30 18:01

developer   ~76793

The most common is to have it lowercase, right? That will bring more order and minimize errors.

No, i have a lot oif client using PNG …

I think we should add a different ticket for that. Similar situation maybe, but on survey taking side.

Ther are NO issue here : we check on lowercase on both and we don't RENAME file without reason.
guest

guest

2023-08-31 09:04

viewer   ~76801

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=35423
guest

guest

2023-08-31 09:04

viewer   ~76802

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=35422
DenisChenu

DenisChenu

2023-08-31 10:21

developer   ~76806

Need master ? Right ? (unsure)
gabrieljenik

gabrieljenik

2023-08-31 15:17

manager   ~76811

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3417
gabrieljenik

gabrieljenik

2023-08-31 15:22

manager   ~76813

See : > https://github.com/LimeSurvey/LimeSurvey/blob/6ad5917fc5a9c7355588d895e68cb2ed8bffef09/application/controllers/UploaderController.php#L181
Maybe need to lowercase the list too.

19067 created
guest

guest

2023-08-31 15:36

viewer   ~76816

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=35427

Related Changesets

LimeSurvey: 5.x 653df3d0

2023-08-31 09:04:27

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed bug 18911 import of theme fails if it contains resource with uppercase extension (#3373)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18911
mod - application/helpers/admin/template_helper.php Diff File

LimeSurvey: 5.x 653df3d0

2023-08-31 09:04:27

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed bug 18911 import of theme fails if it contains resource with uppercase extension (#3373)

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18911
mod - application/helpers/admin/template_helper.php Diff File

LimeSurvey: master 55a18dd8

2023-08-31 15:36:42

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed bug 18911 import of theme fails if it contains resource with uppercase extension (03417)

Checking extension in lower case in filter function.

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
18911
mod - application/helpers/admin/template_helper.php Diff File

Issue History

Date Modified Username Field Change
2023-06-23 09:44 ritapas New Issue
2023-06-23 09:44 ritapas File Added: testExtBug_v2.zip
2023-06-23 09:57 DenisChenu Note Added: 75814
2023-06-23 09:57 DenisChenu Bug heat 0 => 2
2023-06-23 09:57 DenisChenu Summary import of theme fails if it contains resource with particular extension (LS3, LS5) => import of theme fails if it contains resource with uppercase extension (LS3, LS5)
2023-06-23 09:59 DenisChenu Note Added: 75815
2023-06-23 10:18 ritapas Note Added: 75816
2023-06-23 10:18 ritapas Bug heat 2 => 4
2023-06-23 10:18 ritapas Issue Monitored: ritapas
2023-06-23 10:18 ritapas Bug heat 4 => 6
2023-08-07 23:59 gabrieljenik Status new => acknowledged
2023-08-18 15:02 gabrieljenik Assigned To => DenisChenu
2023-08-18 15:02 gabrieljenik Status acknowledged => ready for code review
2023-08-18 15:02 gabrieljenik Note Added: 76644
2023-08-18 15:02 gabrieljenik Bug heat 6 => 8
2023-08-30 11:58 DenisChenu Status ready for code review => in code review
2023-08-30 11:58 DenisChenu Note Added: 76781
2023-08-30 11:58 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-08-30 16:04 gabrieljenik Note Added: 76790
2023-08-30 16:04 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-08-30 18:01 DenisChenu Note Added: 76793
2023-08-31 09:04 Changeset attached => LimeSurvey 5.x 653df3d0
2023-08-31 09:04 guest Note Added: 76801
2023-08-31 09:04 guest Bug heat 8 => 10
2023-08-31 09:04 Changeset attached => LimeSurvey 5.x 653df3d0
2023-08-31 09:04 guest Note Added: 76802
2023-08-31 10:21 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-08-31 10:21 DenisChenu Status in code review => resolved
2023-08-31 10:21 DenisChenu Resolution open => fixed
2023-08-31 10:21 DenisChenu Note Added: 76806
2023-08-31 15:17 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-08-31 15:17 gabrieljenik Status resolved => ready for code review
2023-08-31 15:17 gabrieljenik Note Added: 76811
2023-08-31 15:21 gabrieljenik Issue cloned: 19067
2023-08-31 15:21 gabrieljenik Relationship added related to 19067
2023-08-31 15:22 gabrieljenik Note Added: 76813
2023-08-31 15:36 Changeset attached => LimeSurvey master 55a18dd8
2023-08-31 15:36 guest Note Added: 76816
2023-08-31 19:20 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-08-31 19:20 DenisChenu Status ready for code review => resolved