View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18313Bug reportsUser / Groups / Rolespublic2022-08-19 15:00
Reporterel_grom Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status feedbackResolutionopen 
Product Version5.3.x 
Summary18313: Permissions via drop-down are not shown
Description

Hi,

On the user management page, if you click on the action button "edit permissions" of any user, you'll see his permission.
But if you select the user and "edit permissions" with the drop-down box on the bottom of the page, you'll see nothing

Steps To Reproduce

Steps to reproduce

Go to the user management page (logged as superadmin or anything that has sufficient permissions)
Choose any user who has some permissions and click on the "Edit permissions" button on the action column. You'll see his effective permissions with checkboxes.
Click Cancel
Choose the same user, select him with the checkbox.
Scroll down to the bottom of the page and choose "Edit permissions" in the drop-down list. You'll see all the checkboxes unchecked

Expected result

We expect that the checkboxes are checked according to the effective permissions the user has.

Actual result

All the checkboxes are unchecked. Like if the user has no permission at all

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)5.3.30+220808
I will donate to the project if issue is resolvedNo
BrowserChrome/Edge
Database type & versionAzure SQL DB
Server OS (if known)Windows 2019
Webserver software & version (if known)Apache
PHP Version7.4.29

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-08-16 16:17

manager   ~71443

Thanks. Bug received.
Will try to reproduce it and be back.

gabrieljenik

gabrieljenik

2022-08-17 15:33

manager   ~71466

Expected result
We expect that the checkboxes are checked according to the effective permissions the user has.

I believe these expectations are not that well.
That dropdown is for setting permissions to multiple users at once.
Overriding permissions.

If multiple users have different permissions, how shall we set checkboxes?
Maybe what's missing is some indications about it?

el_grom

el_grom

2022-08-18 08:39

reporter   ~71473

Hello,

Good point.
May be the naming is not ideal then because it's very confusing. Imo, same action should show same result, whatever the way to display it.

If the target of this drop-down is to be used for multiple item, I sugget to make it grey (/unusable) until 2 or more items are selected.
Or put a banner explaining?

el_grom

el_grom

2022-08-18 08:44

reporter   ~71474

Additional note, due to issue 18316 which makes us use the drop-down for one item, this reinforce the feeling about the 1-item + drop-down list gives the same result as the action button

gabrieljenik

gabrieljenik

2022-08-18 19:44

manager   ~71486

May be the naming is not ideal then because it's very confusing.

Sorry, got lost. Which name?

Imo, same action should show same result, whatever the way to display it.

Agree. No matter how many users you select, mass permission setting it is always showing the checkboxes blanked.
Just to note, mass permission setting is a diffierent action than single user permission setting.

If the target of this drop-down is to be used for multiple item

Could be 1 or many. Usually many, but there is no restriction

Or put a banner explaining?

From your experience, what would the banner should say?

Thanks!

el_grom

el_grom

2022-08-19 09:14

reporter   ~71489

(Sorry, I don't know how to quote)

  • Which name?
    Something mentionning that it's meant to "bulk edit". By "confusing", I meant that both actions are named "Edit permissions" but act differently.
    Or keeping the name but only activating it when 2+ items are selected?
    (suggestions only, tricky matter I admit)

  • The banner could say something like:
    If 2+ items are selected: "You chose to edit multiple users, their actual permissions are not displayable"
    If 1 item is selected: <no banner> but displaying his permission

gabrieljenik

gabrieljenik

2022-08-19 14:56

manager   ~71498

The banner could say something like:
If 2+ items are selected: "You chose to edit multiple users, their actual permissions are not displayable"
If 1 item is selected: <no banner> but displaying his permission

@c_schmitz what do yo think about this?

c_schmitz

c_schmitz

2022-08-19 15:00

administrator   ~71500

Last edited: 2022-08-19 15:00

A very usual design pattern for this situation would be to show the normal permission selection screen, but where the user permissions are different among the selected users, the related box(es) should be greyed out.
If the administrator does not check or uncheck these greyed out box(es), the permission will not be changed on these.

Issue History

Date Modified Username Field Change
2022-08-16 12:04 el_grom New Issue
2022-08-16 16:17 gabrieljenik Assigned To => gabrieljenik
2022-08-16 16:17 gabrieljenik Status new => acknowledged
2022-08-16 16:17 gabrieljenik Note Added: 71443
2022-08-16 16:17 gabrieljenik Bug heat 0 => 2
2022-08-17 15:33 gabrieljenik Status acknowledged => feedback
2022-08-17 15:33 gabrieljenik Note Added: 71466
2022-08-18 08:39 el_grom Note Added: 71473
2022-08-18 08:39 el_grom Bug heat 2 => 4
2022-08-18 08:39 el_grom Status feedback => assigned
2022-08-18 08:44 el_grom Note Added: 71474
2022-08-18 19:44 gabrieljenik Note Added: 71486
2022-08-18 19:44 gabrieljenik Status assigned => feedback
2022-08-19 09:14 el_grom Note Added: 71489
2022-08-19 09:14 el_grom Status feedback => assigned
2022-08-19 14:56 gabrieljenik Note Added: 71498
2022-08-19 14:56 gabrieljenik Status assigned => feedback
2022-08-19 15:00 c_schmitz Note Added: 71500
2022-08-19 15:00 c_schmitz Bug heat 4 => 6
2022-08-19 15:00 c_schmitz Note Edited: 71500