View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
19251Bug reportsConditionspublic2024-01-30 10:18
Reportermarcgold Assigned Totibor.pacalat  
PrioritynormalSeveritypartial_block 
Status resolvedResolutionfixed 
Product Version6.3.x 
Summary19251: Can't add Regex condition in survey
Description

Have tried to add a Regular Expression in Condition Designer - the data entry for the regex does not activate.

Steps To Reproduce

Steps to reproduce

Add conditions in Condition Designer.

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

You can enter data

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

You cant

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)6.4
I will donate to the project if issue is resolvedNo
Browserany
Database type & versionMaria 10
Server OS (if known)Ubuntu
Webserver software & version (if known)Nginx
PHP Version8.2

Users monitoring this issue

There are no users monitoring this issue.

Activities

marcgold

marcgold

2023-11-20 12:47

reporter   ~78534

Quick update on this, I was able to add the regex from the Quick Add conditions screen, However this screen looks a bit weird, with two input boxes at the bottom. Should only be one.
This should probably be a separate ticket.

gabrieljenik

gabrieljenik

2023-12-06 17:32

manager   ~78897

https://github.com/LimeSurvey/LimeSurvey/pull/3657

Regex tab now works..

guest

guest

2023-12-12 17:50

viewer   ~78961

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35844

marcgold

marcgold

2023-12-27 14:55

reporter   ~79072

A fix has been committed to master branch, although the Regex tab now works we cannot actually add a regex to the question.

When you do the regex entered is blank. If you then try and edit it to add it again, it stated that there is an error and the question has not been selected.
Also, trying to use the Quick add conditions which did work now does not at all with the same error.

marcgold

marcgold

2024-01-12 13:03

reporter   ~79156

Just circling back, Regex's still not able to save in either the main condition designer or the quick condition designer since the update to 6.4.1

gabrieljenik

gabrieljenik

2024-01-23 09:34

manager   ~79286

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3710

This second commit deals with some problems found on the QuickAdd Tab.
Very hard to reproduce, sometimes it was possible, then it wasn't any more... so please can you @tibor.pacalat give it an extra focus while reviewing?

marcgold

marcgold

2024-01-23 14:24

reporter   ~79290

I have applied the diff files, and can confirm that the Quick Add panel now adds the Regex and it saves. However the main Conditions pages still saves the regex's blank (ie no conditions).
I will test this shortly in a live survey to see if conditions work as expected.

marcgold

marcgold

2024-01-23 15:15

reporter   ~79293

Tested adding and running a survey adding a regex via the Quick add panel. Works as expected.

gabrieljenik

gabrieljenik

2024-01-23 23:55

manager   ~79303

However the main Conditions pages still saves the regex's blank (ie no conditions).

This is still an issue? I would add it to a different ticket.

marcgold

marcgold

2024-01-29 13:31

reporter   ~79320

Hi Gabriel,

This ticket is the one that deals with the primary condition designer and the regex functionality in that. So technically this the ticket dealing with this issue.
There was an associated issue in the "Quick Add" Conditions as a subset of this screen - the code changes that have been applied to the Quick Add functionality, and I can confirm this now works.

But the original issue within the ticket remains an issue.

tibor.pacalat

tibor.pacalat

2024-01-29 13:55

administrator   ~79321

Hi @marcgold! I am not sure why do you say
| But the original issue within the ticket remains an issue.
Can you explain a bit more?
Original issue:
"Have tried to add a Regular Expression in Condition Designer - the data entry for the regex does not activate."
I have managed to add the regexp condition via condition designer (look at the screenshot) and it works (also, the condition in the survey works as well).

I have tested this in 5.x and it works the same.

guest

guest

2024-01-29 13:57

viewer   ~79322

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35999

marcgold

marcgold

2024-01-29 16:42

reporter   ~79329

Hi Tibor,

The previous message was referring to Gabiel's comment on adding a new ticket. However this does not work for me on 6.4.3 (with your diff changes to the quick add in place).

Here is a link to a Loom Video showing the issue live. https://www.loom.com/share/b2d072c6feec4727833c71ef49d9e093

tibor.pacalat

tibor.pacalat

2024-01-29 17:06

administrator   ~79333

I can see the regex on main conditions page with this fix. This will be resolved with the new release on Monday.

marcgold

marcgold

2024-01-29 17:17

reporter   ~79334

THANK YOU!!! I will pull the diff file and test too.

marcgold

marcgold

2024-01-29 17:27

reporter   ~79336

Again, thank you, confirmed working with the updated file edits :)

LimeBot

LimeBot

2024-01-30 10:18

administrator   ~79344

Fixed in Release 6.4.4+240130

Related Changesets

LimeSurvey: master 20004973

2023-12-12 17:27:11

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 19251: Can't add Regex condition in survey (#3657)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
19251
mod - assets/scripts/admin/conditions.js Diff File

LimeSurvey: master f9bd362b

2024-01-29 13:57:32

Gabriel Jenik


Committer: GitHub Details Diff
Fixed issue 19251: Can't add Regex condition in survey (#3710)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>
Affected Issues
19251
mod - application/views/admin/conditions/includes/quickAddConditionForm.php Diff File
mod - assets/scripts/admin/conditions.js Diff File

Issue History

Date Modified Username Field Change
2023-11-18 18:22 marcgold New Issue
2023-11-20 12:47 marcgold Note Added: 78534
2023-11-20 12:47 marcgold File Added: Screenshot 2023-11-20 at 11.29.40.png
2023-11-20 12:47 marcgold Bug heat 0 => 2
2023-11-30 15:38 gabrieljenik Priority none => normal
2023-11-30 15:42 gabrieljenik Assigned To => gabrieljenik
2023-11-30 15:42 gabrieljenik Status new => assigned
2023-12-06 17:32 gabrieljenik Status assigned => ready for code review
2023-12-06 17:32 gabrieljenik Note Added: 78897
2023-12-06 17:32 gabrieljenik Bug heat 2 => 4
2023-12-06 17:32 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-12-12 16:57 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-12-12 16:57 DenisChenu Status ready for code review => ready for testing
2023-12-12 17:27 tibor.pacalat Status ready for testing => resolved
2023-12-12 17:27 tibor.pacalat Resolution open => fixed
2023-12-12 17:50 Changeset attached => LimeSurvey master 20004973
2023-12-12 17:50 guest Note Added: 78961
2023-12-12 17:50 guest Bug heat 4 => 6
2023-12-27 14:55 marcgold Status resolved => feedback
2023-12-27 14:55 marcgold Resolution fixed => reopened
2023-12-27 14:55 marcgold Complete LimeSurvey version number (& build) 6.3.5 => 6.4
2023-12-27 14:55 marcgold Note Added: 79072
2024-01-12 13:03 marcgold Note Added: 79156
2024-01-12 13:03 marcgold Status feedback => assigned
2024-01-23 09:34 gabrieljenik Status assigned => ready for code review
2024-01-23 09:34 gabrieljenik Note Added: 79286
2024-01-23 14:24 marcgold Note Added: 79290
2024-01-23 15:15 marcgold Note Added: 79293
2024-01-23 23:55 gabrieljenik Note Added: 79303
2024-01-29 13:31 marcgold Note Added: 79320
2024-01-29 13:55 tibor.pacalat Note Added: 79321
2024-01-29 13:55 tibor.pacalat File Added: Screenshot 2024-01-29 at 13.51.18.png
2024-01-29 13:55 tibor.pacalat Bug heat 6 => 8
2024-01-29 13:56 tibor.pacalat Status ready for code review => feedback
2024-01-29 13:57 Changeset attached => LimeSurvey master f9bd362b
2024-01-29 13:57 guest Note Added: 79322
2024-01-29 16:42 marcgold Note Added: 79329
2024-01-29 16:42 marcgold Status feedback => assigned
2024-01-29 17:06 tibor.pacalat Note Added: 79333
2024-01-29 17:06 tibor.pacalat File Added: Screenshot 2024-01-29 at 17.05.26.png
2024-01-29 17:07 tibor.pacalat Status assigned => resolved
2024-01-29 17:07 tibor.pacalat Resolution reopened => fixed
2024-01-29 17:17 marcgold Note Added: 79334
2024-01-29 17:27 marcgold Note Added: 79336
2024-01-30 10:18 LimeBot Note Added: 79344
2024-01-30 10:20 tibor.pacalat Bug heat 8 => 10